-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
♻️ improve error handling of pricing plans in webserver #4980
♻️ improve error handling of pricing plans in webserver #4980
Conversation
Codecov Report
@@ Coverage Diff @@
## master #4980 +/- ##
=========================================
- Coverage 85.5% 78.0% -7.6%
=========================================
Files 1243 586 -657
Lines 51177 28255 -22922
Branches 1084 198 -886
=========================================
- Hits 43764 22042 -21722
+ Misses 7174 6163 -1011
+ Partials 239 50 -189
Flags with carried forward coverage won't be shown. Click here to find out more.
|
e9d13d1
to
bea06e0
Compare
services/web/server/src/simcore_service_webserver/resource_usage/_constants.py
Show resolved
Hide resolved
…k66/osparc-simcore into is922/handle-errors-better
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left some suggestions and comments. thx
services/web/server/src/simcore_service_webserver/resource_usage/_client.py
Show resolved
Hide resolved
services/web/server/src/simcore_service_webserver/resource_usage/_constants.py
Show resolved
Hide resolved
services/web/server/tests/unit/with_dbs/01/test_catalog_api__pricing_plan.py
Show resolved
Hide resolved
services/web/server/tests/unit/with_dbs/01/test_catalog_api__pricing_plan.py
Outdated
Show resolved
Hide resolved
services/web/server/tests/unit/with_dbs/01/test_catalog_api__pricing_plan.py
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks!
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
Code Climate has analyzed commit 0c33755 and detected 0 issues on this pull request. View more on Code Climate. |
What do these changes do?
get_service_pricing_plan
Related issue/s
How to test
run:
services/web/server/tests/unit/with_dbs/01/test_catalog_api__pricing_plan.py
DevOps Checklist