Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

♻️ improve error handling of pricing plans in webserver #4980

Conversation

matusdrobuliak66
Copy link
Contributor

@matusdrobuliak66 matusdrobuliak66 commented Nov 5, 2023

What do these changes do?

  • ♻️ minor improvement of error handling of pricing plans in the webserver (also now handling catalog 404, before everything was mapped to 500)
  • ♻️ adding a unit test that tests endpoint get_service_pricing_plan

Related issue/s

How to test

run:
services/web/server/tests/unit/with_dbs/01/test_catalog_api__pricing_plan.py

DevOps Checklist

@matusdrobuliak66 matusdrobuliak66 self-assigned this Nov 5, 2023
Copy link

codecov bot commented Nov 5, 2023

Codecov Report

Merging #4980 (0c33755) into master (5e3e596) will decrease coverage by 7.6%.
The diff coverage is 57.8%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #4980      +/-   ##
=========================================
- Coverage    85.5%   78.0%    -7.6%     
=========================================
  Files        1243     586     -657     
  Lines       51177   28255   -22922     
  Branches     1084     198     -886     
=========================================
- Hits        43764   22042   -21722     
+ Misses       7174    6163    -1011     
+ Partials      239      50     -189     
Flag Coverage Δ
integrationtests 60.8% <22.2%> (-4.2%) ⬇️
unittests 86.8% <57.8%> (+1.6%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
.../src/simcore_service_payments/services/payments.py 55.5% <ø> (ø)
...core_service_resource_usage_tracker/core/errors.py 100.0% <100.0%> (ø)
...racker/modules/db/repositories/resource_tracker.py 85.2% <ø> (ø)
...rc/simcore_service_webserver/catalog/_constants.py 100.0% <100.0%> (ø)
...ore_service_webserver/resource_usage/_constants.py 100.0% <100.0%> (ø)
...imcore_service_webserver/resource_usage/_client.py 53.4% <50.0%> (-0.2%) ⬇️
...er/src/simcore_service_webserver/catalog/client.py 51.1% <50.0%> (-1.3%) ⬇️
...simcore_service_webserver/resource_usage/_utils.py 76.1% <50.0%> (-6.2%) ⬇️

... and 747 files with indirect coverage changes

@matusdrobuliak66 matusdrobuliak66 force-pushed the is922/handle-errors-better branch from e9d13d1 to bea06e0 Compare November 8, 2023 12:52
@matusdrobuliak66 matusdrobuliak66 changed the title WIP: ♻️ improve error handling of pricing plans in webserver ♻️ improve error handling of pricing plans in webserver Nov 8, 2023
@matusdrobuliak66 matusdrobuliak66 marked this pull request as ready for review November 8, 2023 12:56
@matusdrobuliak66 matusdrobuliak66 added this to the 7peaks milestone Nov 8, 2023
…k66/osparc-simcore into is922/handle-errors-better
Copy link
Member

@pcrespov pcrespov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some suggestions and comments. thx

Copy link
Member

@sanderegg sanderegg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@matusdrobuliak66 matusdrobuliak66 enabled auto-merge (squash) November 10, 2023 16:13
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link

codeclimate bot commented Nov 10, 2023

Code Climate has analyzed commit 0c33755 and detected 0 issues on this pull request.

View more on Code Climate.

@matusdrobuliak66 matusdrobuliak66 merged commit d77e335 into ITISFoundation:master Nov 10, 2023
54 checks passed
@matusdrobuliak66 matusdrobuliak66 deleted the is922/handle-errors-better branch November 10, 2023 17:44
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request Nov 23, 2023
29 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants