Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 parameterized serviceName in the e2e test #5016

Merged

Conversation

matusdrobuliak66
Copy link
Contributor

@matusdrobuliak66 matusdrobuliak66 commented Nov 10, 2023

What do these changes do?

  • 🐛 add serviceName to the parameters so the e2e test can be parametrized

Related issue/s

How to test

Dev Checklist

DevOps Checklist

@matusdrobuliak66 matusdrobuliak66 marked this pull request as ready for review November 10, 2023 17:48
Copy link
Member

@sanderegg sanderegg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you maybe enlighten the subject of your PR?
fix the e2e sounds like a lot for 15 line changes ;)

Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link

codeclimate bot commented Nov 12, 2023

Code Climate has analyzed commit 61639ca and detected 0 issues on this pull request.

View more on Code Climate.

@matusdrobuliak66 matusdrobuliak66 changed the title 🐛 fix e2e 🐛 parameterized serviceName in the e2e test Nov 12, 2023
@matusdrobuliak66 matusdrobuliak66 enabled auto-merge (squash) November 12, 2023 10:06
@matusdrobuliak66 matusdrobuliak66 merged commit 19af489 into ITISFoundation:master Nov 12, 2023
48 checks passed
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request Nov 23, 2023
29 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants