Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Share wallet bug #5021

Merged
merged 3 commits into from
Nov 13, 2023
Merged

Share wallet bug #5021

merged 3 commits into from
Nov 13, 2023

Conversation

ignapas
Copy link
Contributor

@ignapas ignapas commented Nov 13, 2023

What do these changes do?

Fix the problem with sharing wallets

Related issue/s

fixes #5006

How to test

Check that is possible to share wallets again

Dev Checklist

DevOps Checklist

@ignapas ignapas added the bug buggy, it does not work as expected label Nov 13, 2023
@ignapas ignapas self-assigned this Nov 13, 2023
@ignapas ignapas enabled auto-merge (squash) November 13, 2023 10:50
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.3% 0.3% Duplication

Copy link

codeclimate bot commented Nov 13, 2023

Code Climate has analyzed commit dcb1e62 and detected 0 issues on this pull request.

View more on Code Climate.

Copy link
Contributor

@jsaq007 jsaq007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not tested in the UI but the change makes sense

@ignapas ignapas merged commit 0284b24 into ITISFoundation:master Nov 13, 2023
48 checks passed
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request Nov 23, 2023
29 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug buggy, it does not work as expected
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sharing a wallet doesn't work
3 participants