✨🎨 Preferences: Inactivity and Concurrency

[ignapas]

What do these changes do?

• Adds two new preferences: The inactivity and the maximum job concurrency settings

Related issue/s

How to test

Check the preferences dialog for the mentioned properties and check that they change in the DB.
Please review the wordings.

Dev Checklist

• No ENV changes or I properly updated ENV (read the instruction)

DevOps Checklist

[codecov]

Codecov Report

Merging #5024 (f43cf5f) into master (f185eda) will decrease coverage by 3.6%.
The diff coverage is 100.0%.

Additional details and impacted files

@@            Coverage Diff            @@
##           master   #5024      +/-   ##
=========================================
- Coverage    84.8%   81.2%    -3.6%     
=========================================
  Files        1263     526     -737     
  Lines       52019   26670   -25349     
  Branches     1124     198     -926     
=========================================
- Hits        44113   21675   -22438     
+ Misses       7673    4945    -2728     
+ Partials      233      50     -183     

Flag	Coverage Δ
integrationtests	64.9% <100.0%> (+13.1%)	⬆️
unittests	86.4% <100.0%> (+2.4%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files	Coverage Δ
...ore_service_webserver/users/_preferences_models.py	100.0% <100.0%> (ø)

... and 922 files with indirect coverage changes

[elisabettai]

Very nice! Some questions/comments:

Can the "inactivity shutdown" be set to None (so it never happens)? If this is possible,this we should also warn the users that this going to consume credits.

It is not very clear what the concurrent job preference does. We might add a short explanation.

[pcrespov]

👍

[matusdrobuliak66]

👍

[sanderegg]

nice thanks!

for @elisabettai the max concurrent job should allow:

• say you have a pipeline with 10 parallel computational services
• if max concurrent jobs is set to 4, then only 4 will run in parallel (each service consumes 1 machine),
• that also means that if you run this via publicAPI, at most 4 jobs will run in parallel,

[GitHK]

nice 👍

[sonarqubecloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
0.0% Duplication

[codeclimate]

Code Climate has analyzed commit f43cf5f and detected 0 issues on this pull request.

View more on Code Climate.