-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ Is922/add autorecharge functionality #5036
✨ Is922/add autorecharge functionality #5036
Conversation
…iak66/osparc-simcore into is922/auto-recharge-emit-msg
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks really good. some initial comments. I will follow later ...
packages/models-library/src/models_library/rabbitmq_messages.py
Outdated
Show resolved
Hide resolved
services/payments/src/simcore_service_payments/services/payments_methods.py
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
very nice! thanks
services/payments/tests/unit/test_services_auto_recharge_listener.py
Outdated
Show resolved
Hide resolved
packages/pytest-simcore/src/pytest_simcore/helpers/rawdata_fakers.py
Outdated
Show resolved
Hide resolved
packages/pytest-simcore/src/pytest_simcore/helpers/rawdata_fakers.py
Outdated
Show resolved
Hide resolved
services/payments/src/simcore_service_payments/services/payments_methods.py
Outdated
Show resolved
Hide resolved
services/payments/tests/unit/test_services_auto_recharge_listener.py
Outdated
Show resolved
Hide resolved
…usdrobuliak66/osparc-simcore into is922/add-autorecharge-functionality
@pcrespov I will wait for your approval |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Gut gemacht. Thank you!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fantastic! 🎉
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
Code Climate has analyzed commit 1d46a7d and detected 0 issues on this pull request. View more on Code Climate. |
What do these changes do?
NOTE: Introduced variable
PAYMENTS_AUTORECHARGE_ENABLED
to the Payments service. Based on this variable we pay via the payment gateway (pay_with_payment_method). It is a temporary solution so we can turn on/off this functionality.Related issue/s
How to test
Webserver:
pytest tests/unit/test_services_auto_recharge_listener.p
Payments service:
pytest tests/unit/with_dbs/03/products/test_products_rpc.py
Dev Checklist
https://git.speag.com/oSparc/osparc-ops-deployment-configuration/-/merge_requests/158 @YuryHrytsuk @mrnicegyu11
DevOps Checklist
Added to payments service:
PAYMENTS_AUTORECHARGE_DEFAULT_MONTHLY_LIMIT
=10000PAYMENTS_AUTORECHARGE_DEFAULT_TOP_UP_AMOUNT
=100.0PAYMENTS_AUTORECHARGE_MIN_BALANCE_IN_CREDITS
=100PAYMENTS_AUTORECHARGE_ENABLED
=1