🐛🎨 Fixes formatting error in payments and enhances logging and error handling

[pcrespov]

What do these changes do?

A fix, some refactoring and a series of improvements specially in error handling and logging based on manual exploratory testing of payments workflows

• 🐛 Fixes wrong formatting in PaymentsGatewayError
• ✨ new liveness probes (only functionality)
• ♻️ refactored payments rpc. Uses implementation in services.payments
• 🎨 adds rpc for list-payments
• 🎨 improved logging in rpc init&pay flows
• 🎨 Improved error handling on payments-gateway

Related issue/s

• Implements part of One-time-payment in payment service #4657

How to test

Driving tests

• packages/service-library/tests/fastapi/test_http_client.py
• services/payments/tests/unit/test_services_payments_gateway.py
• services/payments/tests/unit/api/test__one_time_payment_workflows.py

Dev Checklist

• No ENV changes or I properly updated ENV (read the instruction)

DevOps

None

[codecov]

Codecov Report

Merging #5037 (f171caa) into master (8f207be) will decrease coverage by 4.1%.
The diff coverage is 70.4%.

Additional details and impacted files

@@            Coverage Diff            @@
##           master   #5037      +/-   ##
=========================================
- Coverage    86.4%   82.3%    -4.1%     
=========================================
  Files        1256     528     -728     
  Lines       51552   21170   -30382     
  Branches     1108     540     -568     
=========================================
- Hits        44547   17431   -27116     
+ Misses       6766    3617    -3149     
+ Partials      239     122     -117     

Flag	Coverage Δ
integrationtests	75.3% <ø> (+15.8%)	⬆️
unittests	86.6% <70.4%> (+1.5%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files	Coverage Δ
.../src/simcore_service_payments/api/rpc/_payments.py	100.0% <100.0%> (+6.5%)	⬆️
...core_service_payments/api/rpc/_payments_methods.py	100.0% <100.0%> (ø)
.../src/simcore_service_payments/services/payments.py	93.7% <100.0%> (+21.8%)	⬆️
...core_service_payments/services/payments_gateway.py	99.0% <95.4%> (+1.2%)	⬆️
.../models-library/src/models_library/healthchecks.py	83.3% <83.3%> (ø)
.../src/simcore_service_payments/services/postgres.py	77.4% <36.3%> (-22.6%)	⬇️
.../simcore_service_payments/services/healthchecks.py	0.0% <0.0%> (ø)

... and 815 files with indirect coverage changes

[sanderegg]

very nice! thanks.

[matusdrobuliak66]

👍

[codeclimate]

Code Climate has analyzed commit f171caa and detected 0 issues on this pull request.

View more on Code Climate.

[sonarqubecloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
0.4% Duplication