Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

⚰️ removing node_rights module from director-v2 #5039

Merged
merged 2 commits into from
Nov 17, 2023

Conversation

GitHK
Copy link
Contributor

@GitHK GitHK commented Nov 16, 2023

What do these changes do?

This piece of code was NEVER used on any deployment.
It's out of date and does not solve anything.

Related issue/s

How to test

Dev Checklist

DevOps Checklist

@GitHK GitHK self-assigned this Nov 16, 2023
@GitHK GitHK added the a:director-v2 issue related with the director-v2 service label Nov 16, 2023
@GitHK GitHK added this to the 7peaks milestone Nov 16, 2023
Copy link

codeclimate bot commented Nov 16, 2023

Code Climate has analyzed commit 75a4dcc and detected 0 issues on this pull request.

View more on Code Climate.

@GitHK GitHK marked this pull request as ready for review November 16, 2023 15:09
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.1% 0.1% Duplication

Copy link

codecov bot commented Nov 16, 2023

Codecov Report

Merging #5039 (75a4dcc) into master (1a4b614) will decrease coverage by 19.0%.
The diff coverage is 86.6%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #5039      +/-   ##
=========================================
- Coverage    87.2%   68.2%   -19.0%     
=========================================
  Files        1253     523     -730     
  Lines       51492   26452   -25040     
  Branches     1108     198     -910     
=========================================
- Hits        44915   18062   -26853     
- Misses       6338    8340    +2002     
+ Partials      239      50     -189     
Flag Coverage Δ
integrationtests 64.7% <86.6%> (-0.2%) ⬇️
unittests 84.5% <26.6%> (-0.5%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...rc/simcore_service_director_v2/core/application.py 97.3% <ø> (-0.1%) ⬇️
...s/dynamic_sidecar/scheduler/_core/_events_utils.py 94.4% <86.6%> (+2.7%) ⬆️

... and 988 files with indirect coverage changes

Copy link
Member

@sanderegg sanderegg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very nice choice of icon. deleting is always good.

@GitHK GitHK merged commit 35a6ef3 into ITISFoundation:master Nov 17, 2023
55 checks passed
@GitHK GitHK deleted the pr-osparc-drop-node-rights branch November 17, 2023 07:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a:director-v2 issue related with the director-v2 service
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants