🐛 getters for user_role and email fixed #5041
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GitHK
force-pushed
the
pr-osparc-fix-broken.coroutine
branch
from
b3321b2 to
9a4beeb
Compare
…arc-simcore-forked into pr-osparc-fix-broken.coroutine
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #5041 +/- ##
========================================
+ Coverage 85.8% 87.9% +2.1%
========================================
Files 1254 1108 -146
Lines 51596 46699 -4897
Branches 1088 572 -516
========================================
- Hits 44309 41089 -3220
+ Misses 7047 5481 -1566
+ Partials 240 129 -111
Flags with carried forward coverage won't be shown. Click here to find out more.
|
added 3 commits
November 17, 2023 08:37
GitHK
commented
Nov 17, 2023
services/director-v2/src/simcore_service_director_v2/modules/osparc_variables_substitutions.py
Outdated
Show resolved
Hide resolved
sanderegg
reviewed
Nov 17, 2023
...director-v2/src/simcore_service_director_v2/modules/db/repositories/services_environments.py
Outdated
Show resolved
Hide resolved
sanderegg
requested changes
Nov 17, 2023
packages/postgres-database/src/simcore_postgres_database/utils_users.py
Outdated
Show resolved
Hide resolved
packages/postgres-database/src/simcore_postgres_database/utils_users.py
Outdated
Show resolved
Hide resolved
...director-v2/src/simcore_service_director_v2/modules/db/repositories/services_environments.py
Outdated
Show resolved
Hide resolved
...director-v2/src/simcore_service_director_v2/modules/db/repositories/services_environments.py
Outdated
Show resolved
Hide resolved
...director-v2/src/simcore_service_director_v2/modules/db/repositories/services_environments.py
Outdated
Show resolved
Hide resolved
sanderegg
requested changes
Nov 17, 2023
pcrespov
approved these changes
Nov 17, 2023
services/director-v2/src/simcore_service_director_v2/modules/osparc_variables_substitutions.py
Outdated
Show resolved
Hide resolved
![codeclimate[bot]](https://avatars.githubusercontent.com/in/9403?s=60&v=4){kind=small}
...director-v2/src/simcore_service_director_v2/modules/db/repositories/services_environments.py
Outdated
Show resolved
Hide resolved
…arc-simcore-forked into pr-osparc-fix-broken.coroutine
sanderegg
requested changes
Nov 20, 2023
packages/postgres-database/src/simcore_postgres_database/utils_users.py
Outdated
Show resolved
Hide resolved
packages/postgres-database/src/simcore_postgres_database/utils_users.py
Outdated
Show resolved
Hide resolved
services/director-v2/src/simcore_service_director_v2/modules/db/repositories/users.py
Outdated
Show resolved
Hide resolved
added 3 commits
November 20, 2023 13:56
…arc-simcore-forked into pr-osparc-fix-broken.coroutine
|
Code Climate has analyzed commit d9dd8d9 and detected 0 issues on this pull request. View more on Code Climate. |
|
Kudos, SonarCloud Quality Gate passed!
|
19 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
Fixed
OSPARC_VARIABLE_USER_EMAILandOSPARC_VARIABLE_USER_ROLE. Coroutines were not awaited.strtype is enforced.Related issue/s
How to test
Dev Checklist
DevOps Checklist