Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Only show total user's credit in the current wallet #5050

Merged
merged 4 commits into from
Nov 20, 2023
Merged

Only show total user's credit in the current wallet #5050

merged 4 commits into from
Nov 20, 2023

Conversation

jsaq007
Copy link
Contributor

@jsaq007 jsaq007 commented Nov 20, 2023 •
edited by pcrespov
Loading

What do these changes do?

Screenshot 2023-11-20 at 09 28 46

Related issue/s

How to test

Dev Checklist

DevOps Checklist

@jsaq007 jsaq007 self-assigned this Nov 20, 2023
@jsaq007 jsaq007 requested a review from ignapas as a code owner November 20, 2023 08:31
@jsaq007 jsaq007 enabled auto-merge (squash) November 20, 2023 08:31
sanderegg
sanderegg approved these changes Nov 20, 2023
View reviewed changes
Copy link
Member

@sanderegg sanderegg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great! don't forget to set the milestone, labels etc etc...

elisabettai
elisabettai approved these changes Nov 20, 2023
View reviewed changes
Copy link
Collaborator

@elisabettai elisabettai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Than you, looks much better!

pcrespov
pcrespov requested changes Nov 20, 2023
View reviewed changes
Copy link
Member

@pcrespov pcrespov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please consider removing commented code

@codeclimate CodeClimate
Copy link

codeclimate bot commented Nov 20, 2023

Code Climate has analyzed commit d9029a3 and detected 0 issues on this pull request.

View more on Code Climate.

@sonarqubecloud SonarQubeCloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.4% 0.4% Duplication

pcrespov
pcrespov approved these changes Nov 20, 2023
View reviewed changes
Copy link
Member

@pcrespov pcrespov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the confusion. all good. thx!

@jsaq007 jsaq007 merged commit 3e3a25c into ITISFoundation:master Nov 20, 2023
49 checks passed
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request Nov 22, 2023
Closed
19 tasks
@elisabettai elisabettai mentioned this pull request Nov 23, 2023
Closed
1 task
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request Nov 23, 2023
Closed
29 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sanderegg sanderegg sanderegg approved these changes

@pcrespov pcrespov pcrespov approved these changes

@elisabettai elisabettai elisabettai approved these changes

@GitHK GitHK GitHK approved these changes

@ignapas ignapas ignapas approved these changes

@mguidon mguidon Awaiting requested review from mguidon

Assignees

@jsaq007 jsaq007

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@jsaq007 @ignapas @GitHK @elisabettai @pcrespov @sanderegg