Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 📝 Fix batch get payment #5060

Merged
merged 8 commits into from
Nov 21, 2023

Conversation

pcrespov
Copy link
Member

@pcrespov pcrespov commented Nov 21, 2023

What do these changes do?

  • 🐛 Avoids calling gateway with empty body to avoid 422 response. This fixes an undesired side effect observed in the front-end during one-time-payment where the "pay" button wheel will just turn...
  • 📝 Document openapi specs expected by the payments-gateway system.

Related issue/s

How to test

cd services/payments
make install-dev
pytest  -vv -k test_payments_gateway_get_batch_with_no_items tests

Dev Checklist

DevOps

None

@pcrespov pcrespov self-assigned this Nov 21, 2023
@pcrespov pcrespov added the a:payments payments service label Nov 21, 2023
@pcrespov pcrespov added this to the 7peaks milestone Nov 21, 2023
Copy link

codecov bot commented Nov 21, 2023

Codecov Report

Merging #5060 (baae6f8) into master (56fe30c) will decrease coverage by 24.3%.
The diff coverage is 100.0%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #5060      +/-   ##
=========================================
- Coverage    85.2%   60.9%   -24.3%     
=========================================
  Files        1263     565     -698     
  Lines       51909   27780   -24129     
  Branches     1114     198     -916     
=========================================
- Hits        44261   16941   -27320     
- Misses       7415   10789    +3374     
+ Partials      233      50     -183     
Flag Coverage Δ
integrationtests 59.6% <ø> (+16.0%) ⬆️
unittests 92.4% <100.0%> (+7.4%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...core_service_payments/services/payments_gateway.py 99.0% <100.0%> (+<0.1%) ⬆️

... and 1065 files with indirect coverage changes

@pcrespov pcrespov added the a:doc documentation, reporting, admin tasks label Nov 21, 2023
@pcrespov pcrespov enabled auto-merge (squash) November 21, 2023 14:08
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.4% 0.4% Duplication

Copy link

Please retry analysis of this Pull-Request directly on SonarCloud.

Copy link

codeclimate bot commented Nov 21, 2023

Code Climate has analyzed commit baae6f8 and detected 0 issues on this pull request.

View more on Code Climate.

@pcrespov pcrespov merged commit d459139 into ITISFoundation:master Nov 21, 2023
55 checks passed
@pcrespov pcrespov deleted the is4657/fix-batchGet-payment branch November 21, 2023 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a:doc documentation, reporting, admin tasks a:payments payments service
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants