Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 Avoid displaying confusing message when editing workbench #5062

Merged
merged 9 commits into from
Nov 22, 2023
Merged

🐛 Avoid displaying confusing message when editing workbench #5062

merged 9 commits into from
Nov 22, 2023

Conversation

ignapas
Copy link
Contributor

@ignapas ignapas commented Nov 21, 2023 •
edited
Loading

@ignapas ignapas added bug buggy, it does not work as expected a:frontend issue affecting the front-end (area group) labels Nov 21, 2023
@ignapas ignapas added this to the 7peaks milestone Nov 21, 2023
@ignapas ignapas self-assigned this Nov 21, 2023
pcrespov
pcrespov requested changes Nov 21, 2023
View reviewed changes
Copy link
Member

@pcrespov pcrespov left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TIP to make a good PR:

  • create a readable title since it will display in the release notes
  • move the issue number as an enumeration to the message. It renders and links the issues. Example, if you write - #1189, it renders as
  • add the keyword "close" or "fixes" to automatically closed the resolved case

SEE https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue#linking-a-pull-request-to-an-issue-using-a-keyword

services/static-webserver/client/source/class/osparc/desktop/StudyEditor.js Outdated Show resolved Hide resolved
@ignapas ignapas requested a review from jsaq007 November 21, 2023 16:19
@ignapas ignapas changed the title 🐛 TIP: Message fix (issue #1189) 🐛 Avoid displaying confusing message when editing workbench Nov 21, 2023
@ignapas ignapas requested a review from pcrespov November 21, 2023 16:24
@ignapas ignapas enabled auto-merge (squash) November 21, 2023 16:27
elisabettai
elisabettai approved these changes Nov 21, 2023
View reviewed changes
Copy link
Collaborator

@elisabettai elisabettai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That was quick, thank you!

sanderegg
sanderegg approved these changes Nov 21, 2023
View reviewed changes
Copy link
Member

@sanderegg sanderegg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing semicolon...

sanderegg
sanderegg approved these changes Nov 21, 2023
View reviewed changes
Copy link
Member

@sanderegg sanderegg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and thanks a lot!

@sonarqubecloud SonarQubeCloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@codeclimate CodeClimate
Copy link

codeclimate bot commented Nov 22, 2023

Code Climate has analyzed commit bac01ac and detected 0 issues on this pull request.

View more on Code Climate.

@ignapas ignapas merged commit fe16dd2 into ITISFoundation:master Nov 22, 2023
49 checks passed
This was referenced Nov 22, 2023
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sanderegg sanderegg sanderegg approved these changes

@pcrespov pcrespov pcrespov approved these changes

@elisabettai elisabettai elisabettai approved these changes

@GitHK GitHK GitHK approved these changes

@jsaq007 jsaq007 jsaq007 approved these changes

Assignees

@ignapas ignapas

Labels
a:frontend issue affecting the front-end (area group) bug buggy, it does not work as expected
Projects
None yet
Milestone
7peaks
Development

Successfully merging this pull request may close these issues.

Confusing error message appears when adding/removing/changing a node
6 participants
@ignapas @jsaq007 @GitHK @elisabettai @pcrespov @sanderegg