-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🎨 Removes two_factor_enabled
column in users db (🗃️)
#5063
🎨 Removes two_factor_enabled
column in users db (🗃️)
#5063
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #5063 +/- ##
========================================
- Coverage 87.2% 85.9% -1.4%
========================================
Files 1263 1110 -153
Lines 51955 46781 -5174
Branches 1115 572 -543
========================================
- Hits 45343 40187 -5156
- Misses 6373 6465 +92
+ Partials 239 129 -110
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
Code Climate has analyzed commit 69e81e4 and detected 0 issues on this pull request. View more on Code Climate. |
What do these changes do?
After discussing with @sanderegg I realized that the future 2FA system will actually be implemented in separated user preferences table instead of as "yet another" column of
users
.For the moment we keep the previous 2FA policy based on user roles despite the fact that it has so many inconveniences as describe in the other pr. Here we just make it a bit more restrictive such that only testers are exempt to comply with this step.
users
tableRelated issue/s
How to test
in place
Dev Checklist
DevOps Checklist
None