Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🎨 Removes two_factor_enabled column in users db (🗃️) #5063

Merged
merged 4 commits into from
Nov 22, 2023

Conversation

pcrespov
Copy link
Member

What do these changes do?

After discussing with @sanderegg I realized that the future 2FA system will actually be implemented in separated user preferences table instead of as "yet another" column of users.

For the moment we keep the previous 2FA policy based on user roles despite the fact that it has so many inconveniences as describe in the other pr. Here we just make it a bit more restrictive such that only testers are exempt to comply with this step.

  • Removes column added to the users table

Related issue/s

How to test

in place

Dev Checklist

DevOps Checklist

None

@pcrespov pcrespov self-assigned this Nov 21, 2023
@pcrespov pcrespov added a:webserver issue related to the webserver service a:database associated to postgres service and postgres-database package labels Nov 21, 2023
@pcrespov pcrespov added this to the 7peaks milestone Nov 21, 2023
@pcrespov pcrespov enabled auto-merge (squash) November 21, 2023 18:40
Copy link

codecov bot commented Nov 21, 2023

Codecov Report

Merging #5063 (69e81e4) into master (6911102) will decrease coverage by 1.4%.
The diff coverage is 100.0%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           master   #5063     +/-   ##
========================================
- Coverage    87.2%   85.9%   -1.4%     
========================================
  Files        1263    1110    -153     
  Lines       51955   46781   -5174     
  Branches     1115     572    -543     
========================================
- Hits        45343   40187   -5156     
- Misses       6373    6465     +92     
+ Partials      239     129    -110     
Flag Coverage Δ
integrationtests 64.8% <100.0%> (-0.1%) ⬇️
unittests 85.6% <100.0%> (+0.5%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...base/src/simcore_postgres_database/models/users.py 94.1% <ø> (ø)
...c/simcore_service_webserver/login/handlers_auth.py 97.8% <100.0%> (ø)

... and 220 files with indirect coverage changes

Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.4% 0.4% Duplication

Copy link

codeclimate bot commented Nov 22, 2023

Code Climate has analyzed commit 69e81e4 and detected 0 issues on this pull request.

View more on Code Climate.

@pcrespov pcrespov merged commit 9afb78a into ITISFoundation:master Nov 22, 2023
55 checks passed
@pcrespov pcrespov deleted the enh/undo-enable-2fa-column branch November 22, 2023 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a:database associated to postgres service and postgres-database package a:webserver issue related to the webserver service
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants