✨Clusters-keeper: add CLUSTERS_KEEPER_COMPUTATIONAL_BACKEND_DOCKER_IMAGE_TAG ENV #5066
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YuryHrytsuk
approved these changes
Nov 22, 2023
YuryHrytsuk
reviewed
Nov 22, 2023
services/clusters-keeper/src/simcore_service_clusters_keeper/core/settings.py
Show resolved
Hide resolved
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #5066 +/- ##
=========================================
- Coverage 87.2% 82.0% -5.3%
=========================================
Files 1237 647 -590
Lines 51409 25497 -25912
Branches 1115 618 -497
=========================================
- Hits 44842 20909 -23933
+ Misses 6328 4456 -1872
+ Partials 239 132 -107
Flags with carried forward coverage won't be shown. Click here to find out more.
|
matusdrobuliak66
approved these changes
Nov 22, 2023
sanderegg
force-pushed
the
add-env-for-dask-sidecar-image-tag
branch
from
bf2662a to
52dfc05
Compare
pcrespov
approved these changes
Nov 22, 2023
mrnicegyu11
approved these changes
Nov 22, 2023
GitHK
approved these changes
Nov 22, 2023
|
Code Climate has analyzed commit d624135 and detected 0 issues on this pull request. View more on Code Climate. |
sanderegg
force-pushed
the
add-env-for-dask-sidecar-image-tag
branch
from
d624135 to
7153464
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
This was referenced Nov 22, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
This PR introduces the CLUSTERS_KEEPER_COMPUTATIONAL_BACKEND_DOCKER_IMAGE_TAG environment variable that allows to set the image tag of the deployed dask-sidecar in the external clusters.
Related issue/s
How to test
Dev Checklist
DevOps Checklist