Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

♻️ minor cleanup #5067

Merged
merged 2 commits into from
Nov 22, 2023
Merged

Conversation

pcrespov
Copy link
Member

@pcrespov pcrespov commented Nov 22, 2023

What do these changes do?

Related issue/s

How to test

Dev Checklist

DevOps Checklist

@pcrespov pcrespov added this to the 7peaks milestone Nov 22, 2023
@pcrespov pcrespov self-assigned this Nov 22, 2023
@pcrespov pcrespov enabled auto-merge (squash) November 22, 2023 10:13
Copy link

codecov bot commented Nov 22, 2023

Codecov Report

Merging #5067 (6751b27) into master (9f2bcc0) will decrease coverage by 18.3%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #5067      +/-   ##
=========================================
- Coverage    85.1%   66.8%   -18.3%     
=========================================
  Files        1263     315     -948     
  Lines       51955   15288   -36667     
  Branches     1115       0    -1115     
=========================================
- Hits        44220   10215   -34005     
+ Misses       7503    5073    -2430     
+ Partials      232       0     -232     
Flag Coverage Δ
unittests 66.8% <ø> (-18.3%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...rver/src/simcore_service_webserver/api_keys/_db.py 94.2% <ø> (-0.2%) ⬇️

... and 1092 files with indirect coverage changes

Copy link

codeclimate bot commented Nov 22, 2023

Code Climate has analyzed commit 6751b27 and detected 0 issues on this pull request.

View more on Code Climate.

Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.4% 0.4% Duplication

@pcrespov pcrespov merged commit 0177abf into ITISFoundation:master Nov 22, 2023
54 of 55 checks passed
@pcrespov pcrespov deleted the maintenance/cleanup branch November 22, 2023 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants