Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨Docker pull script uses --ignore-pull-failures flag #5076

Merged

Conversation

sanderegg
Copy link
Member

@sanderegg sanderegg commented Nov 23, 2023

What do these changes do?

This PR adds the --ignore-pull-failures flag such that if an invalid image is pulled using the pull script it will not fail the other image pulls but complete them.

Related issue/s

How to test

Dev Checklist

DevOps Checklist

@sanderegg sanderegg self-assigned this Nov 23, 2023
@sanderegg sanderegg added this to the 7peaks milestone Nov 23, 2023
Copy link
Member

@mrnicegyu11 mrnicegyu11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

less failures! the future, already today!

Copy link

codeclimate bot commented Nov 23, 2023

Code Climate has analyzed commit ce8dd9a and detected 0 issues on this pull request.

View more on Code Climate.

Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link

codecov bot commented Nov 23, 2023

Codecov Report

Merging #5076 (ce8dd9a) into master (f386472) will decrease coverage by 14.8%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #5076      +/-   ##
=========================================
- Coverage    80.2%   65.4%   -14.8%     
=========================================
  Files        1170     528     -642     
  Lines       47268   26526   -20742     
  Branches     1114       0    -1114     
=========================================
- Hits        37944   17371   -20573     
- Misses       9083    9155      +72     
+ Partials      241       0     -241     
Flag Coverage Δ
integrationtests 63.7% <ø> (+10.0%) ⬆️
unittests 98.3% <ø> (+19.8%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
.../simcore_service_autoscaling/utils/utils_docker.py 98.9% <ø> (ø)

... and 945 files with indirect coverage changes

@sanderegg sanderegg requested a review from mguidon November 23, 2023 14:27
@sanderegg sanderegg merged commit 71c04cc into ITISFoundation:master Nov 23, 2023
55 checks passed
@sanderegg sanderegg deleted the enhancement/ignore-pull-failures branch November 23, 2023 14:32
@sanderegg sanderegg modified the milestones: 7peaks, Kobayashi Maru Nov 23, 2023
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request Jan 8, 2024
33 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants