-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 Fix log streaming issues #5104
🐛 Fix log streaming issues #5104
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #5104 +/- ##
=========================================
- Coverage 87.3% 66.4% -21.0%
=========================================
Files 1267 596 -671
Lines 52079 29227 -22852
Branches 1129 198 -931
=========================================
- Hits 45507 19424 -26083
- Misses 6332 9753 +3421
+ Partials 240 50 -190
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job. Left some comments for your consideration. We should also discuss about error handling at some point. We need to find a common policy for the api-server.
services/api-server/src/simcore_service_api_server/api/dependencies/rabbitmq.py
Show resolved
Hide resolved
services/api-server/src/simcore_service_api_server/api/dependencies/rabbitmq.py
Outdated
Show resolved
Hide resolved
services/api-server/src/simcore_service_api_server/api/dependencies/rabbitmq.py
Outdated
Show resolved
Hide resolved
services/api-server/src/simcore_service_api_server/api/dependencies/rabbitmq.py
Outdated
Show resolved
Hide resolved
services/api-server/src/simcore_service_api_server/api/dependencies/rabbitmq.py
Outdated
Show resolved
Hide resolved
services/api-server/src/simcore_service_api_server/api/dependencies/rabbitmq.py
Outdated
Show resolved
Hide resolved
services/api-server/src/simcore_service_api_server/api/dependencies/rabbitmq.py
Outdated
Show resolved
Hide resolved
services/api-server/src/simcore_service_api_server/api/dependencies/rabbitmq.py
Outdated
Show resolved
Hide resolved
services/api-server/src/simcore_service_api_server/api/dependencies/rabbitmq.py
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
supernice, thanks, I left some minor comments, good luck with this!
services/api-server/src/simcore_service_api_server/api/routes/solvers_jobs_getters.py
Outdated
Show resolved
Hide resolved
services/api-server/src/simcore_service_api_server/models/schemas/jobs.py
Show resolved
Hide resolved
services/api-server/src/simcore_service_api_server/services/log_streaming.py
Show resolved
Hide resolved
services/api-server/src/simcore_service_api_server/api/routes/solvers_jobs_getters.py
Show resolved
Hide resolved
Kudos, SonarCloud Quality Gate passed!
|
Code Climate has analyzed commit dba4b44 and detected 0 issues on this pull request. View more on Code Climate. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉 great work!
services/api-server/src/simcore_service_api_server/api/routes/solvers_jobs_getters.py
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just a few questions around. otherwise great. thanks!
What do these changes do?
LogDistributor
) which subscribes to the log exchange in the RabbitMQ services and distributes the logs from different jobs to the correspondingLogStreamer
sLogStreamer
is constructed and it registers itself with theLogDistributor
.LogStreamer
as otherwise logs are lost when streaming. Seemingly that was the cause of Logs disappearing on their way from computational sidecar to api-server #5096Related issue/s
How to test
Dev Checklist
DevOps Checklist