Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨add preference to allow data collections form services #5112

Merged

Conversation

GitHK
Copy link
Contributor

@GitHK GitHK commented Nov 30, 2023

What do these changes do?

Inside the Preferences, in products where payments are enabled there is now a new sections under General Settings, referring to Privacy settings.

The user can now opt out of the gathering of metrics from services, such as s4l (for now this is the only supported service).

I tried to keep some very neutral and generating working here. I would kindly ask @eofli to review it and let me know how to change it.

Screenshot 2023-11-30 at 15 27 57

Related issue/s

How to test

Dev Checklist

DevOps Checklist

@GitHK GitHK self-assigned this Nov 30, 2023
@GitHK GitHK added a:webserver issue related to the webserver service a:director-v2 issue related with the director-v2 service labels Nov 30, 2023
@GitHK GitHK added this to the Kobayashi Maru milestone Nov 30, 2023
Copy link

codecov bot commented Nov 30, 2023

Codecov Report

Merging #5112 (1b5e809) into master (9302f8b) will increase coverage by 0.1%.
The diff coverage is 89.7%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           master   #5112     +/-   ##
========================================
+ Coverage    87.2%   87.4%   +0.1%     
========================================
  Files        1275    1068    -207     
  Lines       52358   46926   -5432     
  Branches     1133     540    -593     
========================================
- Hits        45689   41028   -4661     
+ Misses       6429    5777    -652     
+ Partials      240     121    -119     
Flag Coverage Δ
integrationtests 63.5% <88.5%> (-0.1%) ⬇️
unittests 85.1% <66.6%> (-0.1%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...rary/src/models_library/shared_user_preferences.py 100.0% <100.0%> (ø)
...or_v2/modules/db/repositories/projects_networks.py 69.5% <ø> (ø)
...dules/db/repositories/user_preferences_frontend.py 100.0% <100.0%> (ø)
...modules/dynamic_sidecar/scheduler/_core/_events.py 99.3% <100.0%> (+<0.1%) ⬆️
...simcore_service_webserver/users/_preferences_db.py 100.0% <100.0%> (ø)
...ore_service_webserver/users/_preferences_models.py 100.0% <100.0%> (ø)
...es/dynamic_sidecar/docker_service_specs/sidecar.py 85.7% <60.0%> (-2.5%) ⬇️
...s/dynamic_sidecar/scheduler/_core/_events_utils.py 93.6% <84.6%> (-0.9%) ⬇️

... and 213 files with indirect coverage changes

@GitHK GitHK changed the title ✨ [backend] add preference to allow metrics collection for user ✨add preference to allow data collections form services Nov 30, 2023
@GitHK GitHK marked this pull request as ready for review November 30, 2023 15:29
Copy link
Member

@pcrespov pcrespov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool!
Have some thoughts about how you retrieve the config details in the backend

@eofli
Copy link

eofli commented Dec 1, 2023

Hi, here is my suggestion for the text in this window

General Settings

  • Credits Indicator
    Show Indicator {Dropdown}
    Show Warning When Credits Below {number}

  • Automatic Shutdown of Idle Instances
    Enter 0 to disable this function
    Idle Time Before Closing (in minutes) {number}

  • Concurrent Jobs
    Maximum Number of Concurrent Jobs {number}

  • Privacy Settings
    Help us improve Sim4Life user experience
    {Checkbox} Share usage data

@GitHK
Copy link
Contributor Author

GitHK commented Dec 1, 2023

Hi, here is my suggestion for the text in this window

General Settings

  • Credits Indicator
    Show Indicator {Dropdown}
    Show Warning When Credits Below {number}
  • Automatic Shutdown of Idle Instances
    Enter 0 to disable this function
    Idle Time Before Closing (in minutes) {number}
  • Concurrent Jobs
    Maximum Number of Concurrent Jobs {number}
  • Privacy Settings
    Help us improve Sim4Life user experience
    {Checkbox} Share usage data

And here are the updated texts. Thanks a lot for the feedback!

Screenshot 2023-12-01 at 13 53 52

@GitHK GitHK force-pushed the pr-osparc-disable-user-metrics-via-preferences branch from 71c1f62 to 4c11385 Compare December 5, 2023 11:26
Copy link
Contributor

@ignapas ignapas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@GitHK the text changes and italics use, is it something coming from POs / App team or just your own suggestion?

@GitHK
Copy link
Contributor Author

GitHK commented Dec 5, 2023

@GitHK the text changes and italics use, is it something coming from POs / App team or just your own suggestion?

@ignapas it's a suggestion from Erdem if you scroll this discussion you can see he asked for this. here is a reference #5112 (comment)

Andrei Neagu added 2 commits December 5, 2023 15:46
…ub.com:GitHK/osparc-simcore-forked into pr-osparc-disable-user-metrics-via-preferences
@GitHK GitHK requested a review from ignapas December 5, 2023 14:48
GitHK and others added 3 commits December 6, 2023 06:52
@GitHK GitHK requested a review from jsaq007 December 6, 2023 13:52
Copy link

codeclimate bot commented Dec 11, 2023

Code Climate has analyzed commit 1b5e809 and detected 0 issues on this pull request.

View more on Code Climate.

Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.1% 0.1% Duplication

@GitHK GitHK merged commit 4cfa318 into ITISFoundation:master Dec 11, 2023
55 checks passed
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request Jan 8, 2024
33 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a:director-v2 issue related with the director-v2 service a:webserver issue related to the webserver service
Projects
None yet
Development

Successfully merging this pull request may close these issues.

user can opt out of being monitored in the preferences and dynamic sidecar no longer exposes metrics
7 participants