-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨add preference to allow data collections form services #5112
✨add preference to allow data collections form services #5112
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #5112 +/- ##
========================================
+ Coverage 87.2% 87.4% +0.1%
========================================
Files 1275 1068 -207
Lines 52358 46926 -5432
Branches 1133 540 -593
========================================
- Hits 45689 41028 -4661
+ Misses 6429 5777 -652
+ Partials 240 121 -119
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool!
Have some thoughts about how you retrieve the config details in the backend
...-v2/src/simcore_service_director_v2/modules/dynamic_sidecar/scheduler/_core/_events_utils.py
Show resolved
Hide resolved
services/static-webserver/client/source/class/osparc/desktop/preferences/pages/GeneralPage.js
Outdated
Show resolved
Hide resolved
Hi, here is my suggestion for the text in this window General Settings
|
And here are the updated texts. Thanks a lot for the feedback! |
71c1f62
to
4c11385
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@GitHK the text changes and italics use, is it something coming from POs / App team or just your own suggestion?
@ignapas it's a suggestion from Erdem if you scroll this discussion you can see he asked for this. here is a reference #5112 (comment) |
services/static-webserver/client/source/class/osparc/desktop/preferences/pages/BasePage.js
Outdated
Show resolved
Hide resolved
services/static-webserver/client/source/class/osparc/desktop/preferences/pages/GeneralPage.js
Outdated
Show resolved
Hide resolved
…ub.com:GitHK/osparc-simcore-forked into pr-osparc-disable-user-metrics-via-preferences
…ub.com:GitHK/osparc-simcore-forked into pr-osparc-disable-user-metrics-via-preferences
services/static-webserver/client/source/class/osparc/desktop/preferences/pages/GeneralPage.js
Show resolved
Hide resolved
services/static-webserver/client/source/class/osparc/desktop/preferences/pages/GeneralPage.js
Outdated
Show resolved
Hide resolved
services/static-webserver/client/source/class/osparc/desktop/preferences/pages/GeneralPage.js
Outdated
Show resolved
Hide resolved
services/static-webserver/client/source/class/osparc/desktop/preferences/pages/GeneralPage.js
Show resolved
Hide resolved
services/static-webserver/client/source/class/osparc/desktop/preferences/pages/GeneralPage.js
Show resolved
Hide resolved
…-user-metrics-via-preferences
Code Climate has analyzed commit 1b5e809 and detected 0 issues on this pull request. View more on Code Climate. |
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
What do these changes do?
Inside the Preferences, in products where payments are enabled there is now a new sections under
General Settings
, referring toPrivacy settings
.The user can now opt out of the gathering of metrics from services, such as s4l (for now this is the only supported service).
I tried to keep some very neutral and generating working here. I would kindly ask @eofli to review it and let me know how to change it.
Related issue/s
How to test
Dev Checklist
DevOps Checklist