Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Bugfix/instrumentation queue #5122

Conversation

matusdrobuliak66
Copy link
Contributor

@matusdrobuliak66 matusdrobuliak66 commented Dec 4, 2023

What do these changes do?

  • 🐛 Bugfix/instrumentation queue
    • divide exclusive and nonexclusive queues (they behave differently on _unsubscribe_from_rabbitmq

Related issue/s

How to test

Dev Checklist

DevOps Checklist

matusdrobuliak66 and others added 22 commits November 10, 2023 15:49
…iak66/osparc-simcore into is922/auto-recharge-emit-msg
@matusdrobuliak66 matusdrobuliak66 self-assigned this Dec 4, 2023
@matusdrobuliak66 matusdrobuliak66 added the bug buggy, it does not work as expected label Dec 4, 2023
@matusdrobuliak66 matusdrobuliak66 added this to the Kobayashi Maru milestone Dec 4, 2023
Copy link

codecov bot commented Dec 4, 2023

Codecov Report

Merging #5122 (bfeaf87) into master (7920def) will decrease coverage by 6.5%.
The diff coverage is 89.0%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #5122      +/-   ##
=========================================
- Coverage    87.3%   80.9%    -6.5%     
=========================================
  Files        1273     528     -745     
  Lines       52317   26694   -25623     
  Branches     1133     198     -935     
=========================================
- Hits        45720   21605   -24115     
+ Misses       6357    5039    -1318     
+ Partials      240      50     -190     
Flag Coverage Δ
integrationtests 63.5% <65.4%> (-1.4%) ⬇️
unittests 86.4% <89.0%> (+1.2%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...server/notifications/_rabbitmq_consumers_common.py 100.0% <100.0%> (ø)
...tifications/_rabbitmq_exclusive_queue_consumers.py 64.2% <100.0%> (ø)
.../simcore_service_webserver/notifications/plugin.py 100.0% <100.0%> (ø)
...ications/_rabbitmq_nonexclusive_queue_consumers.py 79.3% <79.3%> (ø)

... and 871 files with indirect coverage changes

@matusdrobuliak66 matusdrobuliak66 marked this pull request as ready for review December 4, 2023 11:00
Copy link
Member

@sanderegg sanderegg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you for taking care of that one!

Copy link
Member

@pcrespov pcrespov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some suggestions to consider before merging. thx!

@matusdrobuliak66 matusdrobuliak66 enabled auto-merge (squash) December 5, 2023 10:12
Copy link

sonarqubecloud bot commented Dec 8, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link

codeclimate bot commented Dec 8, 2023

Code Climate has analyzed commit bfeaf87 and detected 0 issues on this pull request.

View more on Code Climate.

@matusdrobuliak66 matusdrobuliak66 merged commit 6cc1bbe into ITISFoundation:master Dec 8, 2023
55 checks passed
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request Jan 8, 2024
33 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug buggy, it does not work as expected
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants