🐛Bugfix/autoscaling does not scale above limit #5129
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sanderegg
force-pushed
the
bugfix/autoscaling-does-not-scale-above-limit
branch
from
97fd641 to
e6365cc
Compare
sanderegg
requested review from
mguidon,
matusdrobuliak66,
GitHK,
pcrespov,
bisgaard-itis,
mrnicegyu11 and
YuryHrytsuk
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #5129 +/- ##
=========================================
+ Coverage 64.8% 86.8% +21.9%
=========================================
Files 526 838 +312
Lines 26660 37406 +10746
Branches 198 209 +11
=========================================
+ Hits 17292 32485 +15193
+ Misses 9318 4871 -4447
Partials 50 50
Flags with carried forward coverage won't be shown. Click here to find out more.
|
sanderegg
force-pushed
the
bugfix/autoscaling-does-not-scale-above-limit
branch
from
e1e133f to
b12e742
Compare
GitHK
approved these changes
Dec 5, 2023
services/autoscaling/src/simcore_service_autoscaling/modules/auto_scaling_core.py
Outdated
Show resolved
Hide resolved
services/autoscaling/src/simcore_service_autoscaling/modules/auto_scaling_core.py
Outdated
Show resolved
Hide resolved
services/autoscaling/tests/unit/test_modules_auto_scaling_computational.py
Show resolved
Hide resolved
YuryHrytsuk
approved these changes
Dec 5, 2023
matusdrobuliak66
approved these changes
Dec 5, 2023
1 task
commit 96ba5f5 Author: sanderegg <[email protected]> Date: Tue Dec 5 10:19:31 2023 +0100 use method to create hardware constraint and read
sanderegg
force-pushed
the
bugfix/autoscaling-does-not-scale-above-limit
branch
from
0da3023 to
91e4ffa
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
|
Code Climate has analyzed commit 0417a59 and detected 0 issues on this pull request. View more on Code Climate. |
15 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
During testing it was found that in the use case where a user starts 16 jobs:
EC2_INSTANCES_MAX_INSTANCESset to 10,This PR changes that behavior by creating up to
EC2_INSTANCES_MAX_INSTANCESinstances (currently hard-coded to 10) so that the computation may still go through.also includes:
#5137
Related issue/s
How to test
Dev Checklist
DevOps Checklist