Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🔨 e2e/adding rut test #5135

Merged

Conversation

matusdrobuliak66
Copy link
Contributor

@matusdrobuliak66 matusdrobuliak66 commented Dec 5, 2023

What do these changes do?

  • 🔨 e2e/adding rut test
    • this is a temporary/monitoring/"stress" test that can be removed after some time. Its purpose is to observe whether when we create a new job RUT is informed about it correctly

Related issue/s

How to test

Dev Checklist

DevOps Checklist

matusdrobuliak66 and others added 29 commits November 10, 2023 15:49
…iak66/osparc-simcore into is922/auto-recharge-emit-msg
@matusdrobuliak66 matusdrobuliak66 self-assigned this Dec 5, 2023
@matusdrobuliak66 matusdrobuliak66 added this to the Kobayashi Maru milestone Dec 5, 2023
@matusdrobuliak66 matusdrobuliak66 marked this pull request as ready for review December 5, 2023 09:00
Copy link
Contributor

@GitHK GitHK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Q: @matusdrobuliak66 why would you say this is temproray? Why not just leave it here?

Copy link
Member

@pcrespov pcrespov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pair reviewed.
Thx!

Copy link

codecov bot commented Dec 5, 2023

Codecov Report

Merging #5135 (4b62283) into master (6cc1bbe) will decrease coverage by 28.3%.
Report is 1 commits behind head on master.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #5135      +/-   ##
=========================================
- Coverage    88.8%   60.5%   -28.3%     
=========================================
  Files         939     528     -411     
  Lines       41890   26694   -15196     
  Branches     1053     198     -855     
=========================================
- Hits        37225   16169   -21056     
- Misses       4435   10475    +6040     
+ Partials      230      50     -180     
Flag Coverage Δ
integrationtests 60.5% <ø> (-4.4%) ⬇️
unittests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

see 747 files with indirect coverage changes

Copy link
Member

@sanderegg sanderegg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

Copy link

sonarqubecloud bot commented Dec 8, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link

codeclimate bot commented Dec 8, 2023

Code Climate has analyzed commit 4b62283 and detected 0 issues on this pull request.

View more on Code Climate.

@matusdrobuliak66 matusdrobuliak66 enabled auto-merge (squash) December 8, 2023 10:12
@matusdrobuliak66 matusdrobuliak66 merged commit 32b1cc5 into ITISFoundation:master Dec 8, 2023
55 checks passed
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request Jan 8, 2024
33 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants