Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Billing center: Various fixes #5145

Merged
merged 34 commits into from
Dec 6, 2023
Merged

Conversation

ignapas
Copy link
Contributor

@ignapas ignapas commented Dec 6, 2023

What do these changes do?

  • Corrects typo in WS message name causing the "add payment window" to not close after success
  • "Buy credits window" also closes after successful payment
  • After payment, transactions table is updated and shown

How to test

  • Open billing center in a deploy with FAKE payments (only for testing)
  • add payment-method
    should get
image -

@ignapas ignapas added bug buggy, it does not work as expected a:frontend issue affecting the front-end (area group) labels Dec 6, 2023
@ignapas ignapas self-assigned this Dec 6, 2023
@ignapas ignapas enabled auto-merge (squash) December 6, 2023 14:56
@pcrespov pcrespov changed the title 🐛 Corrected typo 🐛 Front-end: Corrected typo in payment-methods's ACK events Dec 6, 2023
@ignapas ignapas disabled auto-merge December 6, 2023 15:40
@ignapas ignapas changed the title 🐛 Front-end: Corrected typo in payment-methods's ACK events 🐛 Billing center: Various fixes Dec 6, 2023
@ignapas ignapas enabled auto-merge (squash) December 6, 2023 16:42
Copy link

sonarqubecloud bot commented Dec 6, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link

codeclimate bot commented Dec 6, 2023

Code Climate has analyzed commit 8e08aa9 and detected 0 issues on this pull request.

View more on Code Climate.

Copy link

codecov bot commented Dec 6, 2023

Codecov Report

Merging #5145 (8e08aa9) into master (d57990f) will decrease coverage by 26.4%.
The diff coverage is 0.0%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #5145      +/-   ##
=========================================
- Coverage    67.6%   41.3%   -26.4%     
=========================================
  Files         536     315     -221     
  Lines       25326   15283   -10043     
  Branches      232       0     -232     
=========================================
- Hits        17141    6313   -10828     
- Misses       8135    8970     +835     
+ Partials       50       0      -50     
Flag Coverage Δ
integrationtests 41.3% <0.0%> (-24.7%) ⬇️
unittests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...simcore_service_webserver/payments/_onetime_api.py 33.9% <0.0%> (ø)

... and 337 files with indirect coverage changes

@pcrespov pcrespov disabled auto-merge December 6, 2023 19:16
@pcrespov
Copy link
Member

pcrespov commented Dec 6, 2023

@ignapas Tested locally and works as expected.

@pcrespov pcrespov merged commit 7920def into ITISFoundation:master Dec 6, 2023
55 checks passed
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request Jan 8, 2024
33 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a:frontend issue affecting the front-end (area group) bug buggy, it does not work as expected
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants