✨Computational backend: allow to set custom ec2 tags (⚠️ devops)

[sanderegg]

What do these changes do?

This PR allows to set ENV to define specific tags on EC2 instances created in external clusters to allow checking costs
These tags will be shown in the AWS console and may be used for filtering EC2s (for example to follow costs).

Related issue/s

• fixes Add tags to EC2 autoscaled machines for easy retrieval (user_id, wallet_id, ....) #5087 by passing user_id/wallet_id primary machine tags to the worker machines

How to test

Dev Checklist

• No ENV changes or I properly updated ENV (read the instruction)
  related MR: https://git.speag.com/oSparc/osparc-ops-deployment-configuration/-/merge_requests/203

DevOps Checklist

New environment variables:

Clusters-keeper:

• PRIMARY_EC2_INSTANCES_CUSTOM_TAGS to add specific tags on the computational cluster primary machine
• WORKERS_EC2_INSTANCES_CUSTOM_TAGS to add specific tags on the computational cluster worker machine(s)

Autoscaling:

• EC2_INSTANCES_CUSTOM_TAGS to add specific tags on autoscaled worker machine(s)

[codecov]

Codecov Report

Merging #5147 (cded45f) into master (32b1cc5) will increase coverage by 0.0%.
The diff coverage is 100.0%.

Additional details and impacted files

@@          Coverage Diff           @@
##           master   #5147   +/-   ##
======================================
  Coverage    87.3%   87.4%           
======================================
  Files        1275    1275           
  Lines       52349   52358    +9     
  Branches     1133    1133           
======================================
+ Hits        45753   45765   +12     
+ Misses       6356    6353    -3     
  Partials      240     240           

Flag	Coverage Δ
integrationtests	64.8% <ø> (-0.1%)	⬇️
unittests	85.2% <100.0%> (+<0.1%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files	Coverage Δ
packages/aws-library/src/aws_library/ec2/client.py	100.0% <100.0%> (ø)
packages/aws-library/src/aws_library/ec2/models.py	88.0% <100.0%> (+0.8%)	⬆️
...g/src/simcore_service_autoscaling/core/settings.py	97.8% <100.0%> (+<0.1%)	⬆️
...e_service_autoscaling/modules/auto_scaling_core.py	95.1% <100.0%> (ø)
...vice_autoscaling/modules/auto_scaling_mode_base.py	100.0% <100.0%> (ø)
...scaling/modules/auto_scaling_mode_computational.py	100.0% <100.0%> (ø)
...e_autoscaling/modules/auto_scaling_mode_dynamic.py	100.0% <100.0%> (ø)
...src/simcore_service_autoscaling/utils/utils_ec2.py	100.0% <100.0%> (ø)
...c/simcore_service_clusters_keeper/core/settings.py	95.6% <100.0%> (+<0.1%)	⬆️
...imcore_service_clusters_keeper/modules/clusters.py	100.0% <ø> (ø)
... and 2 more

... and 6 files with indirect coverage changes

[pcrespov]

🎉

[sonarqubecloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
0.0% Duplication

[codeclimate]

Code Climate has analyzed commit cded45f and detected 0 issues on this pull request.

View more on Code Climate.

[YuryHrytsuk]

Thank you 👍

Let's link the related ops-config PR so that we can double check that ENV is configure properly

https://git.speag.com/oSparc/osparc-ops-deployment-configuration/-/merge_requests/203

[sanderegg]

Thank you 👍

Let's link the related ops-config PR so that we can double check that ENV is configure properly

https://git.speag.com/oSparc/osparc-ops-deployment-configuration/-/merge_requests/203

@YuryHrytsuk yes I already added it up there. thanks for the review!

[bisgaard-itis]

Cool! Thanks,
just a single question