-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 fix dynamic-sidecar preferences save
and before shutdown event
ordering
#5156
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
preferences save
and before shutdown event
ordering
Code Climate has analyzed commit c4b59ce and detected 0 issues on this pull request. View more on Code Climate. |
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #5156 +/- ##
=========================================
+ Coverage 60.9% 87.8% +26.9%
=========================================
Files 204 56 -148
Lines 11026 2760 -8266
Branches 198 0 -198
=========================================
- Hits 6720 2425 -4295
+ Misses 4256 335 -3921
+ Partials 50 0 -50
Flags with carried forward coverage won't be shown. Click here to find out more.
|
What do these changes do?
User services rely on the
before_shutdown
hook to move the preferences in the correct folder. Saving them AFTER the hook runs makes more sense.Related issue/s
How to test
Dev Checklist
DevOps Checklist