Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 fix dynamic-sidecar preferences save and before shutdown event ordering #5156

Merged
merged 2 commits into from
Dec 11, 2023

Conversation

GitHK
Copy link
Contributor

@GitHK GitHK commented Dec 11, 2023

What do these changes do?

User services rely on the before_shutdown hook to move the preferences in the correct folder. Saving them AFTER the hook runs makes more sense.

Related issue/s

How to test

Dev Checklist

DevOps Checklist

@GitHK GitHK self-assigned this Dec 11, 2023
@GitHK GitHK added a:dynamic-sidecar dynamic-sidecar service bug buggy, it does not work as expected labels Dec 11, 2023
@GitHK GitHK marked this pull request as ready for review December 11, 2023 15:49
Copy link
Member

@mguidon mguidon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

Copy link
Member

@sanderegg sanderegg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@GitHK GitHK enabled auto-merge (squash) December 11, 2023 16:09
@GitHK GitHK changed the title 🐛 fix dynamic-sidecar pretences save and shutdown event ordering 🐛 fix dynamic-sidecar preferences save and before shutdown event ordering Dec 11, 2023
Copy link

codeclimate bot commented Dec 11, 2023

Code Climate has analyzed commit c4b59ce and detected 0 issues on this pull request.

View more on Code Climate.

Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.1% 0.1% Duplication

Copy link

codecov bot commented Dec 11, 2023

Codecov Report

Merging #5156 (c4b59ce) into master (df8953b) will increase coverage by 26.9%.
The diff coverage is 66.6%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #5156      +/-   ##
=========================================
+ Coverage    60.9%   87.8%   +26.9%     
=========================================
  Files         204      56     -148     
  Lines       11026    2760    -8266     
  Branches      198       0     -198     
=========================================
- Hits         6720    2425    -4295     
+ Misses       4256     335    -3921     
+ Partials       50       0      -50     
Flag Coverage Δ
integrationtests ?
unittests 87.8% <66.6%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...vice_dynamic_sidecar/modules/long_running_tasks.py 95.2% <66.6%> (+60.7%) ⬆️

... and 186 files with indirect coverage changes

@GitHK GitHK merged commit 2572fd4 into ITISFoundation:master Dec 11, 2023
55 checks passed
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request Jan 8, 2024
33 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a:dynamic-sidecar dynamic-sidecar service bug buggy, it does not work as expected
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants