Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛Computational backend: ensure log level is set properly + increased tracing #5164

Merged
merged 2 commits into from
Dec 13, 2023

Conversation

sanderegg
Copy link
Member

@sanderegg sanderegg commented Dec 12, 2023

What do these changes do?

Ensure log level is properly set via CLUSTERS_KEEPER_LOGLEVEL and then LOG_LEVEL

Related issue/s

How to test

Dev Checklist

DevOps Checklist

Copy link

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link

codeclimate bot commented Dec 12, 2023

Code Climate has analyzed commit a5898ee and detected 0 issues on this pull request.

View more on Code Climate.

Copy link

codecov bot commented Dec 12, 2023

Codecov Report

Merging #5164 (a5898ee) into master (6432d8f) will increase coverage by 18.2%.
The diff coverage is 100.0%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #5164      +/-   ##
=========================================
+ Coverage    69.4%   87.6%   +18.2%     
=========================================
  Files        1200    1185      -15     
  Lines       49293   49391      +98     
  Branches     1140     752     -388     
=========================================
+ Hits        34240   43312    +9072     
+ Misses      14815    5921    -8894     
+ Partials      238     158      -80     
Flag Coverage Δ
integrationtests 64.9% <ø> (+13.0%) ⬆️
unittests 85.3% <100.0%> (+1.5%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...-sidecar/src/simcore_service_dask_sidecar/tasks.py 92.5% <100.0%> (ø)

... and 499 files with indirect coverage changes

@sanderegg sanderegg requested a review from mguidon December 12, 2023 17:22
@sanderegg sanderegg merged commit f10e307 into ITISFoundation:master Dec 13, 2023
54 checks passed
@sanderegg sanderegg deleted the dask-sidecar/add-tracing branch December 13, 2023 06:52
@sanderegg sanderegg added the t:maintenance Some planned maintenance work label Dec 22, 2023
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request Jan 8, 2024
33 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a:clusters-keeper t:maintenance Some planned maintenance work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants