Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Bring back progress for duplicating studies #5191

Merged
merged 1 commit into from
Dec 19, 2023

Conversation

jsaq007
Copy link
Contributor

@jsaq007 jsaq007 commented Dec 19, 2023

What do these changes do?

Bring the duplicate progress bar back as this was causing error which could have prevented rendering.

2023-12-19 18 45 38

Related issue/s

Relates to https://z43.manuscript.com/f/cases/190810/New-feedback-Studies-disappear

How to test

Duplicate a large study and refresh the page
PASS: If this commit fixes the issue you should see all studies in the dashboard including the new duplicate loading
FAIL: All studies in the dashboard disappear

Dev Checklist

DevOps Checklist

Copy link

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link
Member

@mguidon mguidon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thats clearly not the latest c++ standard...

@wvangeit
Copy link
Contributor

Thx for looking into this.

@jsaq007 jsaq007 added this to the Kobayashi Maru milestone Dec 19, 2023
@jsaq007 jsaq007 added bug buggy, it does not work as expected a:frontend issue affecting the front-end (area group) labels Dec 19, 2023
Copy link
Contributor

@ignapas ignapas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@jsaq007 jsaq007 merged commit d333f16 into ITISFoundation:master Dec 19, 2023
48 checks passed
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request Jan 8, 2024
33 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a:frontend issue affecting the front-end (area group) bug buggy, it does not work as expected
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants