Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛Dynamic scheduler is using the wrong information for hardware info #5196

Conversation

sanderegg
Copy link
Member

@sanderegg sanderegg commented Dec 20, 2023

What do these changes do?

The director-v2 was asking for the default pricing info for some unknown reason??
it is already passed by the webserver.

Related issue/s

How to test

Dev Checklist

DevOps Checklist

@sanderegg sanderegg added the a:director-v2 issue related with the director-v2 service label Dec 20, 2023
@sanderegg sanderegg added this to the Kobayashi Maru milestone Dec 20, 2023
@sanderegg sanderegg self-assigned this Dec 20, 2023
Copy link

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link

codecov bot commented Dec 20, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (1fb269d) 87.3% compared to head (4f35dde) 68.5%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #5196      +/-   ##
=========================================
- Coverage    87.3%   68.5%   -18.9%     
=========================================
  Files        1290     532     -758     
  Lines       52888   26839   -26049     
  Branches     1157     202     -955     
=========================================
- Hits        46204   18395   -27809     
- Misses       6434    8394    +1960     
+ Partials      250      50     -200     
Flag Coverage Δ
integrationtests 64.9% <ø> (-0.1%) ⬇️
unittests 84.6% <ø> (-0.6%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...modules/dynamic_sidecar/scheduler/_core/_events.py 99.3% <ø> (-0.1%) ⬇️
...s/dynamic_sidecar/scheduler/_core/_events_utils.py 93.8% <ø> (+0.8%) ⬆️

... and 1021 files with indirect coverage changes

@sanderegg sanderegg merged commit 63903eb into ITISFoundation:master Dec 21, 2023
54 checks passed
@sanderegg sanderegg deleted the dyn-backend/use-proper-hardware-info branch December 21, 2023 07:02
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request Jan 8, 2024
33 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a:director-v2 issue related with the director-v2 service
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant