Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

⚗️Dynamic backend: need more CPUs for dy-proxy #5197

Merged

Conversation

sanderegg
Copy link
Member

@sanderegg sanderegg commented Dec 21, 2023

What do these changes do?

Increases the CPU margin by 0.2

Related issue/s

How to test

Dev Checklist

DevOps Checklist

@sanderegg sanderegg added the a:webserver issue related to the webserver service label Dec 21, 2023
@sanderegg sanderegg added this to the Kobayashi Maru milestone Dec 21, 2023
@sanderegg sanderegg self-assigned this Dec 21, 2023
Copy link
Contributor

@matusdrobuliak66 matusdrobuliak66 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link

codecov bot commented Dec 21, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (63903eb) 87.3% compared to head (35446f1) 81.1%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #5197      +/-   ##
=========================================
- Coverage    87.3%   81.1%    -6.2%     
=========================================
  Files        1290     532     -758     
  Lines       52877   26839   -26038     
  Branches     1157     202     -955     
=========================================
- Hits        46202   21793   -24409     
+ Misses       6425    4996    -1429     
+ Partials      250      50     -200     
Flag Coverage Δ
integrationtests 64.8% <100.0%> (-0.1%) ⬇️
unittests 86.4% <100.0%> (+1.2%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...simcore_service_webserver/projects/projects_api.py 84.3% <100.0%> (ø)

... and 877 files with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a:webserver issue related to the webserver service
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants