🐛Hotfix: Dynamic-backend shall work even if resources were initially empty #5205
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sanderegg
requested review from
pcrespov,
GitHK and
matusdrobuliak66
as code owners
wvangeit
approved these changes
Dec 22, 2023
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5205 +/- ##
=========================================
+ Coverage 85.2% 86.4% +1.2%
=========================================
Files 1291 320 -971
Lines 52913 15381 -37532
Branches 1157 0 -1157
=========================================
- Hits 45083 13302 -31781
+ Misses 7587 2079 -5508
+ Partials 243 0 -243
Flags with carried forward coverage won't be shown. Click here to find out more.
|
bisgaard-itis
approved these changes
Dec 22, 2023
sanderegg
force-pushed
the
hotfix/allow-empty-initial-resources
branch
from
495e408 to
8ad7a34
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
Sometimes a project service resources are empty due to historical reasons.
This PR allows to use defaults in case this happens and will fill the missing data on the go.
Potentially shall be hotfixed to sim4life.io
Related issue/s
How to test
Dev Checklist
DevOps Checklist