Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🎨 Clusters-keeper: No need to install AWS CLI, it is already in AMI #5287

Merged

Conversation

sanderegg
Copy link
Member

@sanderegg sanderegg commented Jan 31, 2024

What do these changes do?

Since the AMI shall already have the AWS-cli installed. there is no need to do it here.
This will make startup faster.

Related issue/s

How to test

Dev Checklist

DevOps Checklist

@sanderegg sanderegg added this to the This is Sparta! milestone Jan 31, 2024
@sanderegg sanderegg self-assigned this Jan 31, 2024
Copy link

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

Copy link

codecov bot commented Jan 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (ffc15b7) 87.3% compared to head (44c792d) 65.8%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #5287      +/-   ##
=========================================
- Coverage    87.3%   65.8%   -21.5%     
=========================================
  Files        1316     566     -750     
  Lines       53816   27819   -25997     
  Branches     1170     202     -968     
=========================================
- Hits        46984   18322   -28662     
- Misses       6583    9447    +2864     
+ Partials      249      50     -199     
Flag Coverage Δ
integrationtests 65.1% <ø> (-0.1%) ⬇️
unittests 94.0% <ø> (+8.9%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
.../simcore_service_clusters_keeper/utils/clusters.py 76.4% <ø> (ø)

... and 1079 files with indirect coverage changes

@sanderegg sanderegg merged commit 732ee73 into ITISFoundation:master Jan 31, 2024
55 checks passed
@sanderegg sanderegg deleted the clusters-keeper/ami-has-awscli branch January 31, 2024 21:38
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request Feb 14, 2024
39 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants