Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🎨 [Frontend] Patch study from Study Editor #5916

Merged
merged 65 commits into from
Jul 15, 2024

Conversation

odeimaiz
Copy link
Member

@odeimaiz odeimaiz commented Jun 5, 2024

What do these changes do?

In order to get rid of the PUT study call, this PR, following this other one, replaces the PUT calls made from the Study Editor with PATCH calls.

For now, until we make sure it works as expected, these patch calls will only be made in the master deployment.

PATCHing

Related issue/s

How to test

Dev-ops checklist

@odeimaiz odeimaiz added t:enhancement Improvement or request on an existing feature a:frontend issue affecting the front-end (area group) labels Jun 5, 2024
@odeimaiz odeimaiz added this to the Leeroy Jenkins milestone Jun 5, 2024
@odeimaiz odeimaiz self-assigned this Jun 5, 2024
Copy link
Member

@pcrespov pcrespov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice.

From the animationsI noticed that when you add a node, the PATCH request they seem to run in pairs ... they look like duplicated. Is there by any chance this is done accidentally or they have a purpose?

image

@odeimaiz
Copy link
Member Author

nice.

From the animationsI noticed that when you add a node, the PATCH request they seem to run in pairs ... they look like duplicated. Is there by any chance this is done accidentally or they have a purpose?

image

One PATCHes the node (probably inputs and inputNodes) and the other one PATCHes the study (ui entry)

@odeimaiz odeimaiz enabled auto-merge (squash) July 11, 2024 18:08
@pcrespov
Copy link
Member

nice.
From the animationsI noticed that when you add a node, the PATCH request they seem to run in pairs ... they look like duplicated. Is there by any chance this is done accidentally or they have a purpose?
image

One PATCHes the node (probably inputs and inputNodes) and the other one PATCHes the study (ui entry)

But according to that it should have different path for the node and the study resp., right?

Copy link
Member

@sanderegg sanderegg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cool!

Copy link
Contributor

@GitHK GitHK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Someone needs to monitor if this has any impact on the backend logic.

@odeimaiz odeimaiz disabled auto-merge July 12, 2024 07:53
@odeimaiz
Copy link
Member Author

nice.
From the animationsI noticed that when you add a node, the PATCH request they seem to run in pairs ... they look like duplicated. Is there by any chance this is done accidentally or they have a purpose?
image

One PATCHes the node (probably inputs and inputNodes) and the other one PATCHes the study (ui entry)

But according to that it should have different path for the node and the study resp., right?

@pcrespov

I better show you live

Copy link
Contributor

@matusdrobuliak66 matusdrobuliak66 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@odeimaiz odeimaiz enabled auto-merge (squash) July 15, 2024 11:54
@odeimaiz odeimaiz merged commit 1fbd9df into ITISFoundation:master Jul 15, 2024
50 checks passed
mrnicegyu11 pushed a commit to mrnicegyu11/osparc-simcore that referenced this pull request Jul 17, 2024
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request Aug 15, 2024
67 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a:frontend issue affecting the front-end (area group) t:enhancement Improvement or request on an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants