-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🎨 [Frontend] Patch study from Study Editor #5916
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One PATCHes the node (probably inputs and inputNodes) and the other one PATCHes the study ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cool!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Someone needs to monitor if this has any impact on the backend logic.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💯
What do these changes do?
In order to get rid of the
PUT
study call, this PR, following this other one, replaces thePUT
calls made from the Study Editor withPATCH
calls.For now, until we make sure it works as expected, these patch calls will only be made in the master deployment.
Related issue/s
How to test
Dev-ops checklist