-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 fixes hanging servicelib tests #5942
🐛 fixes hanging servicelib tests #5942
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #5942 +/- ##
=========================================
+ Coverage 84.5% 88.0% +3.5%
=========================================
Files 10 1438 +1428
Lines 214 59126 +58912
Branches 25 1409 +1384
=========================================
+ Hits 181 52080 +51899
- Misses 23 6750 +6727
- Partials 10 296 +286
Flags with carried forward coverage won't be shown. Click here to find out more.
|
…ken-deferred-tasks-test
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Still draft? description also seems incomplete
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let us know when this is ready.
…ken-deferred-tasks-test
…ken-deferred-tasks-test
…en-deferred-tasks-test
…ken-deferred-tasks-test
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool! Thanks a lot for the fix 👍
…ken-deferred-tasks-test
…ken-deferred-tasks-test
…ken-deferred-tasks-test
…:GitHK/osparc-simcore-forked into pr-osparc-fix-broken-deferred-tasks-test
Co-authored-by: Andrei Neagu <[email protected]>
What do these changes do?
This was very subtle to figure out. Sometimes, when trying to shutdown the
RedisClientSDK
theping
would hang and would impede cancellation of the task. To avoid this we need to lower the timeout of the connection.Changes:
test_lock_acquired_in_parallel_to_update_same_resource
to use sperate connections for each lock acquired in parallelRedisClientSDK
will now fail instead of hanging (added timeout when closing)get_redis_client_sdk
, when used in parallel it could remove some data. Cleanup is done at fixture exittest_exclusive_parallel_lock_is_released_and_reacquired
Possible causes that were not it
RedisClientSDK
could have hanged, but was not the cause.Related issue/s
How to test
Dev-ops checklist