Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨AWS-library: Added interface to AWS SSM #6032

Merged
merged 22 commits into from
Jul 8, 2024

Conversation

sanderegg
Copy link
Member

@sanderegg sanderegg commented Jul 8, 2024

What do these changes do?

This PR introduces in the AWS-library the interfacing with AWS System Manager service (SSM)

Excerpt of AWS SSM:
AWS Systems Manager allows you to safely automate common and repetitive IT operations and management tasks across multiple accounts and AWS Regions.

This PR is a pre-requisite of #5923

In a nutshell, the SSM service allows to run arbitrary commands on EC2 machines when they are running. And this is needed in order to prepare EBS-based buffer machines.

Related issue/s

How to test

Dev-ops checklist

@sanderegg sanderegg self-assigned this Jul 8, 2024
Copy link

codecov bot commented Jul 8, 2024

Codecov Report

Attention: Patch coverage is 94.64286% with 9 lines in your changes missing coverage. Please review.

Project coverage is 87.9%. Comparing base (cafbf96) to head (1279375).
Report is 325 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #6032      +/-   ##
=========================================
+ Coverage    84.5%   87.9%    +3.3%     
=========================================
  Files          10    1432    +1422     
  Lines         214   58735   +58521     
  Branches       25    1403    +1378     
=========================================
+ Hits          181   51636   +51455     
- Misses         23    6806    +6783     
- Partials       10     293     +283     
Flag Coverage Δ
integrationtests 64.7% <ø> (?)
unittests 85.9% <94.6%> (+1.3%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
packages/aws-library/src/aws_library/ec2/client.py 100.0% <100.0%> (ø)
packages/aws-library/src/aws_library/ec2/models.py 88.7% <ø> (ø)
...ckages/aws-library/src/aws_library/ssm/__init__.py 100.0% <100.0%> (ø)
...ackages/aws-library/src/aws_library/ssm/_client.py 100.0% <100.0%> (ø)
...ackages/aws-library/src/aws_library/ssm/_errors.py 100.0% <100.0%> (ø)
...es/service-library/src/servicelib/logging_utils.py 72.6% <100.0%> (ø)
...kages/settings-library/src/settings_library/ssm.py 100.0% <100.0%> (ø)
.../aws-library/src/aws_library/ssm/_error_handler.py 77.5% <77.5%> (ø)

... and 1390 files with indirect coverage changes

@sanderegg sanderegg added this to the Tom Bombadil milestone Jul 8, 2024
@sanderegg sanderegg marked this pull request as ready for review July 8, 2024 08:39
@sanderegg sanderegg requested a review from pcrespov as a code owner July 8, 2024 08:39
Makefile Show resolved Hide resolved
Copy link
Member

@mrnicegyu11 mrnicegyu11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Beautiful code, impressive error handling. Thanks a lot! Only one comment from my side 💪

Copy link
Member

@pcrespov pcrespov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice work! THX

Makefile Show resolved Hide resolved
packages/settings-library/src/settings_library/ssm.py Outdated Show resolved Hide resolved
packages/settings-library/src/settings_library/ssm.py Outdated Show resolved Hide resolved
packages/settings-library/src/settings_library/ssm.py Outdated Show resolved Hide resolved
packages/service-library/src/servicelib/logging_utils.py Outdated Show resolved Hide resolved
packages/aws-library/src/aws_library/ssm/_errors.py Outdated Show resolved Hide resolved
Copy link
Contributor

@matusdrobuliak66 matusdrobuliak66 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cool, thanks!

@sanderegg sanderegg enabled auto-merge (squash) July 8, 2024 09:35
@sanderegg sanderegg merged commit e238d3e into ITISFoundation:master Jul 8, 2024
56 checks passed
@sanderegg sanderegg deleted the ssm/add-client branch July 8, 2024 13:12
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request Aug 15, 2024
67 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants