-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🎨 [Frontend] Node settings labels: support html and ellipsis #6033
Merged
odeimaiz
merged 25 commits into
ITISFoundation:master
from
odeimaiz:feature/comp-desc-app-mode
Jul 10, 2024
Merged
🎨 [Frontend] Node settings labels: support html and ellipsis #6033
odeimaiz
merged 25 commits into
ITISFoundation:master
from
odeimaiz:feature/comp-desc-app-mode
Jul 10, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
odeimaiz
changed the title
RIch and ellipsis
🎨 [Frontend] Node settings labels: support html and ellipsis
Jul 8, 2024
odeimaiz
added
t:enhancement
Improvement or request on an existing feature
a:frontend
issue affecting the front-end (area group)
labels
Jul 8, 2024
…rc-simcore into feature/comp-desc-app-mode
matusdrobuliak66
approved these changes
Jul 9, 2024
sanderegg
approved these changes
Jul 9, 2024
GitHK
reviewed
Jul 9, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fancy
pcrespov
reviewed
Jul 9, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
jsaq007
approved these changes
Jul 10, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍🏼
14 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
a:frontend
issue affecting the front-end (area group)
t:enhancement
Improvement or request on an existing feature
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
We had rich (support html) labels, then we switched to truncatable labels showing ellipsis. Now we have both 👌.
Bonus:
Make the inputs and outputs responsive to size changes. In the App mode this will make the most out of the unused space, expandinf the tooltip.
Rich and Ellipsis:
Responsive:
Related issue/s
closes ITISFoundation/osparc-issues#1272
How to test
Dev-ops checklist