Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🎨 [Frontend] TIP v3 Feedback from 10.07 #6049

Merged
merged 15 commits into from
Jul 11, 2024
Merged

🎨 [Frontend] TIP v3 Feedback from 10.07 #6049

merged 15 commits into from
Jul 11, 2024

Conversation

odeimaiz
Copy link
Member

@odeimaiz odeimaiz commented Jul 10, 2024 •
edited
Loading

What do these changes do?

  • Do not color credits indicator if there was never a transaction. Workaround until transactions per wallet is implemented: do not color it if credits is 0
  • Do not color halo on user menu button
  • Do not show credits indicator on the billable new plans: back to the plus button
  • Do not show low in credits message before starting a billable plan
  • Quick start
    • Only allow closing after last step
    • Show Useful links in last step

NoCredits

Related issue/s

related to ITISFoundation/osparc-issues#1309
related to ITISFoundation/osparc-issues#1409

How to test

Dev-ops checklist

@odeimaiz odeimaiz self-assigned this Jul 10, 2024
@odeimaiz odeimaiz added a:frontend issue affecting the front-end (area group) t:enhancement Improvement or request on an existing feature labels Jul 10, 2024
@odeimaiz odeimaiz added this to the Tom Bombadil milestone Jul 10, 2024
@odeimaiz odeimaiz marked this pull request as ready for review July 10, 2024 12:37
@odeimaiz odeimaiz requested review from jsaq007 and ignapas as code owners July 10, 2024 12:37
mrnicegyu11
mrnicegyu11 approved these changes Jul 10, 2024
View reviewed changes
Copy link
Member

@mrnicegyu11 mrnicegyu11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

pcrespov
pcrespov reviewed Jul 10, 2024
View reviewed changes
Copy link
Member

@pcrespov pcrespov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

jsaq007
jsaq007 approved these changes Jul 11, 2024
View reviewed changes
Copy link
Contributor

@jsaq007 jsaq007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏼

@odeimaiz odeimaiz merged commit ae25f91 into ITISFoundation:master Jul 11, 2024
50 checks passed
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request Jul 12, 2024
Closed
14 tasks
mrnicegyu11 pushed a commit to mrnicegyu11/osparc-simcore that referenced this pull request Jul 17, 2024
@odeimaiz @mrnicegyu11
🎨 [Frontend] TIP v3 Feedback from 10.07 (ITISFoundation#6049)
569bf06
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request Aug 15, 2024
Closed
67 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pcrespov pcrespov pcrespov left review comments

@SCA-ZMT SCA-ZMT SCA-ZMT approved these changes

@matusdrobuliak66 matusdrobuliak66 matusdrobuliak66 approved these changes

@mrnicegyu11 mrnicegyu11 mrnicegyu11 approved these changes

@jsaq007 jsaq007 jsaq007 approved these changes

@ignapas ignapas Awaiting requested review from ignapas ignapas is a code owner

@Konohana0608 Konohana0608 Awaiting requested review from Konohana0608

Assignees

@odeimaiz odeimaiz

Labels
a:frontend issue affecting the front-end (area group) t:enhancement Improvement or request on an existing feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@odeimaiz @jsaq007 @mrnicegyu11 @pcrespov @matusdrobuliak66 @SCA-ZMT