Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛Clusters-keeper/autoscaling: reduce UserData size #6057

Conversation

sanderegg
Copy link
Member

What do these changes do?

Related issue/s

How to test

Dev-ops checklist

@sanderegg sanderegg added a:autoscaling autoscaling service in simcore's stack a:clusters-keeper labels Jul 12, 2024
@sanderegg sanderegg added this to the Tom Bombadil milestone Jul 12, 2024
@sanderegg sanderegg self-assigned this Jul 12, 2024
Copy link

codecov bot commented Jul 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.2%. Comparing base (cafbf96) to head (1171777).
Report is 553 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #6057      +/-   ##
=========================================
+ Coverage    84.5%   88.2%    +3.6%     
=========================================
  Files          10     996     +986     
  Lines         214   44456   +44242     
  Branches       25     282     +257     
=========================================
+ Hits          181   39227   +39046     
- Misses         23    5171    +5148     
- Partials       10      58      +48     
Flag Coverage Δ
integrationtests 64.8% <ø> (?)
unittests 85.6% <100.0%> (+1.0%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
packages/aws-library/src/aws_library/ec2/utils.py 100.0% <100.0%> (ø)
...src/simcore_service_autoscaling/utils/utils_ec2.py 100.0% <ø> (ø)

... and 993 files with indirect coverage changes

@sanderegg sanderegg modified the milestones: Tom Bombadil, Eisbock Aug 13, 2024
@sanderegg sanderegg modified the milestones: Eisbock, Doppelbock Sep 13, 2024
@sanderegg
Copy link
Member Author

replaced by #6361

@sanderegg sanderegg closed this Sep 17, 2024
@sanderegg sanderegg deleted the maintenance/reduce-user-data-size branch September 17, 2024 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a:autoscaling autoscaling service in simcore's stack a:clusters-keeper
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant