-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 Fix create soft link kwargs #6069
Merged
pcrespov
merged 6 commits into
ITISFoundation:master
from
bisgaard-itis:fix-create_soft_link-kwargs
Jul 16, 2024
Merged
🐛 Fix create soft link kwargs #6069
pcrespov
merged 6 commits into
ITISFoundation:master
from
bisgaard-itis:fix-create_soft_link-kwargs
Jul 16, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wvangeit
approved these changes
Jul 16, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🥳🥳🥳🥳
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6069 +/- ##
=========================================
- Coverage 84.5% 62.1% -22.5%
=========================================
Files 10 641 +631
Lines 214 31298 +31084
Branches 25 205 +180
=========================================
+ Hits 181 19438 +19257
- Misses 23 11809 +11786
- Partials 10 51 +41
Flags with carried forward coverage won't be shown. Click here to find out more.
|
pcrespov
approved these changes
Jul 16, 2024
services/api-server/src/simcore_service_api_server/services/study_job_models_converters.py
Show resolved
Hide resolved
GitHK
approved these changes
Jul 16, 2024
matusdrobuliak66
approved these changes
Jul 16, 2024
thanks @pcrespov |
mrnicegyu11
pushed a commit
to mrnicegyu11/osparc-simcore
that referenced
this pull request
Jul 17, 2024
Merged on behalf of @bisgaard-itis . Needed for staging release
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
Related issue/s
How to test
Dev-ops checklist