Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Fix create soft link kwargs #6069

Merged

Conversation

bisgaard-itis
Copy link
Contributor

@bisgaard-itis bisgaard-itis commented Jul 16, 2024

What do these changes do?

  • This PR fixes a bug discovered by @wvangeit.
  • It was caused by the changes I have recently done to how the error handling is done in the api-server
  • I also add a test to ensure the function is covered by our tests. Seems that was not previously the case.

Related issue/s

How to test

Dev-ops checklist

@bisgaard-itis bisgaard-itis marked this pull request as ready for review July 16, 2024 13:18
@bisgaard-itis bisgaard-itis requested a review from pcrespov as a code owner July 16, 2024 13:18
@bisgaard-itis bisgaard-itis self-assigned this Jul 16, 2024
@bisgaard-itis bisgaard-itis added the a:apiserver api-server service label Jul 16, 2024
@bisgaard-itis bisgaard-itis added this to the Tom Bombadil milestone Jul 16, 2024
Copy link
Contributor

@wvangeit wvangeit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥳🥳🥳🥳

@bisgaard-itis bisgaard-itis enabled auto-merge (squash) July 16, 2024 13:22
Copy link

codecov bot commented Jul 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 62.1%. Comparing base (cafbf96) to head (9bb3407).
Report is 349 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #6069      +/-   ##
=========================================
- Coverage    84.5%   62.1%   -22.5%     
=========================================
  Files          10     641     +631     
  Lines         214   31298   +31084     
  Branches       25     205     +180     
=========================================
+ Hits          181   19438   +19257     
- Misses         23   11809   +11786     
- Partials       10      51      +41     
Flag Coverage Δ
integrationtests 59.4% <ø> (?)
unittests 89.8% <100.0%> (+5.2%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...api_server/services/study_job_models_converters.py 95.6% <100.0%> (ø)

... and 650 files with indirect coverage changes

@pcrespov pcrespov disabled auto-merge July 16, 2024 14:06
@pcrespov pcrespov merged commit 9e7cf24 into ITISFoundation:master Jul 16, 2024
36 checks passed
@bisgaard-itis bisgaard-itis deleted the fix-create_soft_link-kwargs branch July 16, 2024 14:07
@bisgaard-itis
Copy link
Contributor Author

thanks @pcrespov

mrnicegyu11 pushed a commit to mrnicegyu11/osparc-simcore that referenced this pull request Jul 17, 2024
Merged on behalf of @bisgaard-itis . Needed for staging release
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request Aug 15, 2024
67 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a:apiserver api-server service
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants