Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

♻️ [Frontend] New projects/groups endpoints #6070

Merged
merged 10 commits into from
Jul 17, 2024
Merged

♻️ [Frontend] New projects/groups endpoints #6070

merged 10 commits into from
Jul 17, 2024

Conversation

odeimaiz
Copy link
Member

@odeimaiz odeimaiz commented Jul 16, 2024 •
edited
Loading

What do these changes do?

Use new /projects/{studyId}/groups/{gId} endpoints for managing study/template collaborators

Existing studies and templates

  • Add collaborators
  • Delete collaborator
  • Update collaborator

After publishing template (long running task)

  • Add collaborators

Related issue/s

follows #6060
related to ITISFoundation/osparc-issues#716

How to test

Dev-ops checklist

@odeimaiz odeimaiz self-assigned this Jul 16, 2024
@odeimaiz odeimaiz changed the title new endpoints ♻️ [Frontend] New projects/accessRights endpoints Jul 16, 2024
@odeimaiz odeimaiz added t:enhancement Improvement or request on an existing feature a:frontend issue affecting the front-end (area group) labels Jul 16, 2024
@odeimaiz odeimaiz added this to the Tom Bombadil milestone Jul 16, 2024
@odeimaiz odeimaiz changed the title ♻️ [Frontend] New projects/accessRights endpoints ♻️ [Frontend] New projects/groups endpoints Jul 16, 2024
@odeimaiz odeimaiz marked this pull request as ready for review July 17, 2024 04:35
@odeimaiz odeimaiz requested review from jsaq007 and ignapas as code owners July 17, 2024 04:35
matusdrobuliak66
matusdrobuliak66 reviewed Jul 17, 2024
View reviewed changes
Copy link
Contributor

@matusdrobuliak66 matusdrobuliak66 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 👍 Should we maybe merge it to my PR so those 2 things go together (so we do not break master)?

@odeimaiz
Copy link
Member Author

Thanks 👍 Should we maybe merge it to my PR so those 2 things go together (so we do not break master)?

Sure, feel free to merge into yours.

@matusdrobuliak66 matusdrobuliak66 merged commit 18cbfde into ITISFoundation:master Jul 17, 2024
50 checks passed
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request Aug 15, 2024
Closed
67 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matusdrobuliak66 matusdrobuliak66 matusdrobuliak66 left review comments

@pcrespov pcrespov pcrespov approved these changes

@GitHK GitHK GitHK approved these changes

@ignapas ignapas ignapas approved these changes

@jsaq007 jsaq007 Awaiting requested review from jsaq007 jsaq007 is a code owner

Assignees

@odeimaiz odeimaiz

Labels
a:frontend issue affecting the front-end (area group) t:enhancement Improvement or request on an existing feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@odeimaiz @ignapas @GitHK @pcrespov @matusdrobuliak66