Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛Docker image pulling: progress issues while pulling ti-postpro #6089

Merged
merged 3 commits into from
Jul 23, 2024

Conversation

sanderegg
Copy link
Member

@sanderegg sanderegg commented Jul 22, 2024

What do these changes do?

ti-postpro:2.0.33 triggered some unforeseen issues in the docker pulling process due it seems to unexpected docker pulling status strings.
This PR shall ensure the process does not fail due to pydantic ValidationError but instead logs the issue so that it can be fixed later as this issue proved very hard to reproduce due to the sheer size of the involved docker image (it triggers timeouts while trying to reproduce in pytest, which is not the observed error).

For info: @Konohana0608

Related issue/s

How to test

Dev-ops checklist

@sanderegg sanderegg added the a:services-library issues on packages/service-libs label Jul 22, 2024
@sanderegg sanderegg added this to the Tom Bombadil milestone Jul 22, 2024
@sanderegg sanderegg self-assigned this Jul 22, 2024
Copy link

codecov bot commented Jul 22, 2024

Codecov Report

Attention: Patch coverage is 85.29412% with 5 lines in your changes missing coverage. Please review.

Project coverage is 87.7%. Comparing base (cafbf96) to head (493e1eb).
Report is 363 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #6089      +/-   ##
=========================================
+ Coverage    84.5%   87.7%    +3.2%     
=========================================
  Files          10    1130    +1120     
  Lines         214   49363   +49149     
  Branches       25     748     +723     
=========================================
+ Hits          181   43335   +43154     
- Misses         23    5866    +5843     
- Partials       10     162     +152     
Flag Coverage Δ
integrationtests 64.7% <ø> (?)
unittests 85.4% <85.2%> (+0.8%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...ges/service-library/src/servicelib/docker_utils.py 94.1% <85.2%> (ø)

... and 1139 files with indirect coverage changes

@sanderegg sanderegg force-pushed the bugfix/docker-pulling branch from 3f9a44c to 493e1eb Compare July 22, 2024 15:11
Copy link

@sanderegg sanderegg requested a review from Konohana0608 July 22, 2024 15:14
@sanderegg sanderegg marked this pull request as ready for review July 22, 2024 15:14
@sanderegg sanderegg requested a review from pcrespov as a code owner July 22, 2024 15:14
@sanderegg sanderegg changed the title 🐛Docker image pulling: progress issues 🐛Docker image pulling: progress issues while pulling ti-postpro Jul 22, 2024
@sanderegg sanderegg requested a review from mguidon July 22, 2024 15:15
@sanderegg sanderegg merged commit 8643100 into ITISFoundation:master Jul 23, 2024
57 checks passed
@sanderegg sanderegg deleted the bugfix/docker-pulling branch July 23, 2024 08:26
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request Aug 15, 2024
67 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a:services-library issues on packages/service-libs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants