🎨E2E for Classic TI: Make test more reliable #6090
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6090 +/- ##
=========================================
+ Coverage 84.5% 88.1% +3.5%
=========================================
Files 10 1444 +1434
Lines 214 59456 +59242
Branches 25 1409 +1384
=========================================
+ Hits 181 52392 +52211
- Misses 23 6768 +6745
- Partials 10 296 +286
Flags with carried forward coverage won't be shown. Click here to find out more. |
GitHK
approved these changes
Jul 23, 2024
pcrespov
approved these changes
Jul 23, 2024
sanderegg
force-pushed
the
e2e/simplify-app-mode
branch
from
81897d5 to
13c0076
Compare
|
|
merci! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
This introduces a context manager to wait for a service running iframe and removes the optional clicking on the start button that is buggy.
Related issue/s
How to test
Dev-ops checklist