Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

♻️E2e: refactor S4L test #6102

Merged

Conversation

sanderegg
Copy link
Member

@sanderegg sanderegg commented Jul 24, 2024

What do these changes do?

  • adds Makefile recipe to test make test-s4l-anywhere
  • improve logs + formatting
  • refactor sim4life test
  • adds --check-videostreaming option when running the s4l test

Warning:

  • playwright integrated chromium, webkit and firefox are unable to connect to videostreaming
  • playwright can install and use chrome/msedge which both are able to connect to videostreaming

NOTE: in order to use chrome/msedge, one needs to run pytest with --browser-channel=chrome instead of ---browser=chromium

NOTE2: @ignapas once the osparc-test-id is attached to the bitrate element we can add a test that the bitrate grows. After discussions with @mguidon we need to check that the value grows over time to finalize the test.

HOw to test

make devenv
cd tests/e2e-playwright
make install-dev
make test-s4l-anywhere

Related issue/s

How to test

Dev-ops checklist

@sanderegg sanderegg added the e2e Bugs found by or related to the end-2-end testing label Jul 24, 2024
@sanderegg sanderegg added this to the Tom Bombadil milestone Jul 24, 2024
@sanderegg sanderegg self-assigned this Jul 24, 2024
Copy link

codecov bot commented Jul 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.9%. Comparing base (cafbf96) to head (75c997b).
Report is 376 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #6102      +/-   ##
=========================================
+ Coverage    84.5%   87.9%    +3.3%     
=========================================
  Files          10    1405    +1395     
  Lines         214   58232   +58018     
  Branches       25    1409    +1384     
=========================================
+ Hits          181   51214   +51033     
- Misses         23    6722    +6699     
- Partials       10     296     +286     
Flag Coverage Δ
integrationtests 64.7% <ø> (?)
unittests 85.9% <ø> (+1.4%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 1363 files with indirect coverage changes

@sanderegg sanderegg force-pushed the e2e/s4l-test-for-videostreaming branch from 225d17e to 975f4ca Compare July 24, 2024 16:21
@sanderegg sanderegg marked this pull request as ready for review July 25, 2024 06:20
Copy link
Contributor

@matusdrobuliak66 matusdrobuliak66 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Super, thanks a lot for the effort!

@sanderegg sanderegg merged commit de48da0 into ITISFoundation:master Jul 25, 2024
13 checks passed
@sanderegg sanderegg deleted the e2e/s4l-test-for-videostreaming branch July 25, 2024 12:45
Copy link

Copy link
Contributor

@YuryHrytsuk YuryHrytsuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks

@matusdrobuliak66 matusdrobuliak66 mentioned this pull request Aug 15, 2024
67 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
e2e Bugs found by or related to the end-2-end testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add test for videostreaming
4 participants