-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
♻️E2e: refactor S4L test #6102
♻️E2e: refactor S4L test #6102
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6102 +/- ##
=========================================
+ Coverage 84.5% 87.9% +3.3%
=========================================
Files 10 1405 +1395
Lines 214 58232 +58018
Branches 25 1409 +1384
=========================================
+ Hits 181 51214 +51033
- Misses 23 6722 +6699
- Partials 10 296 +286
Flags with carried forward coverage won't be shown. Click here to find out more. |
225d17e
to
975f4ca
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Super, thanks a lot for the effort!
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks
What do these changes do?
make test-s4l-anywhere
--check-videostreaming
option when running the s4l testWarning:
NOTE: in order to use chrome/msedge, one needs to run pytest with
--browser-channel=chrome
instead of---browser=chromium
NOTE2: @ignapas once the osparc-test-id is attached to the bitrate element we can add a test that the bitrate grows. After discussions with @mguidon we need to check that the value grows over time to finalize the test.
HOw to test
Related issue/s
How to test
Dev-ops checklist