Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ [Frontend] Leave Organization #6107

Merged
merged 15 commits into from
Jul 29, 2024

Conversation

odeimaiz
Copy link
Member

@odeimaiz odeimaiz commented Jul 24, 2024

What do these changes do?

Should I stay or should I go?

Let users leave an Organization if they got personal access (not through an another organization).

Open Answered questions:

  • What should happen right after? Reload all resources (studies, templates, services, wallets...)? It will trigger a reload of the page.
  • What if the user leaves an organization while having a study open and has access to that study through the quit organization? Not allowed to leave an Organization while a Study is open.

Bonus:

  • Fix no-thumbnail display ("the playwright user cannot open the sleeper service")

LeaveOrganization

Related issue/s

How to test

Dev-ops checklist

@odeimaiz odeimaiz self-assigned this Jul 24, 2024
@odeimaiz odeimaiz added t:enhancement Improvement or request on an existing feature a:frontend issue affecting the front-end (area group) labels Jul 24, 2024
@odeimaiz odeimaiz added this to the Tom Bombadil milestone Jul 24, 2024
@odeimaiz odeimaiz changed the title ✨ [Frontend] Leave Organization and Wallet ✨ [Frontend] Leave Organization Jul 26, 2024
@odeimaiz odeimaiz marked this pull request as ready for review July 26, 2024 08:13
@odeimaiz odeimaiz requested review from jsaq007 and ignapas as code owners July 26, 2024 08:13
Copy link
Member

@sanderegg sanderegg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@elisabettai
Copy link
Collaborator

elisabettai commented Jul 26, 2024

Nice. 🕺🏻

Open questions:
What should happen right after? Reload all resources (studies, templates, services, wallets...)?

Yes, why not? I guess users should see everything up-to-date once they leave an org.

What if the user leaves an organization while having a study open and has access to that study through the quit organization?

Tricky one. Ideally, if you can perform this check when they request to leave the org, you can throw an error saying that they have to close the study first.

@odeimaiz odeimaiz enabled auto-merge (squash) July 26, 2024 08:55
Copy link
Contributor

@GitHK GitHK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Contributor

@jsaq007 jsaq007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏼

@odeimaiz odeimaiz merged commit 1047339 into ITISFoundation:master Jul 29, 2024
50 checks passed
Copy link

@matusdrobuliak66 matusdrobuliak66 mentioned this pull request Aug 15, 2024
67 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a:frontend issue affecting the front-end (area group) t:enhancement Improvement or request on an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants