-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Maintenance: mypy on dynamic-scheduler #6122
Maintenance: mypy on dynamic-scheduler #6122
Conversation
…y-in-dy-scheduler
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6122 +/- ##
=========================================
- Coverage 84.5% 64.0% -20.6%
=========================================
Files 10 591 +581
Lines 214 29357 +29143
Branches 25 205 +180
=========================================
+ Hits 181 18794 +18613
- Misses 23 10512 +10489
- Partials 10 51 +41
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks
services/dynamic-scheduler/src/simcore_service_dynamic_scheduler/core/settings.py
Show resolved
Hide resolved
...dynamic-scheduler/src/simcore_service_dynamic_scheduler/services/director_v2/_thin_client.py
Outdated
Show resolved
Hide resolved
Quality Gate passedIssues Measures |
What do these changes do?
Fixes mypy warnings
Related issue/s
How to test
Dev-ops checklist