Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maintenance: mypy on dynamic-scheduler #6122

Merged
merged 4 commits into from
Jul 30, 2024

Conversation

GitHK
Copy link
Contributor

@GitHK GitHK commented Jul 30, 2024

What do these changes do?

Fixes mypy warnings

Related issue/s

How to test

Dev-ops checklist

@GitHK GitHK self-assigned this Jul 30, 2024
@GitHK GitHK added t:maintenance Some planned maintenance work a:dynamic-scheduler labels Jul 30, 2024
@GitHK GitHK added this to the Tom Bombadil milestone Jul 30, 2024
@GitHK GitHK marked this pull request as ready for review July 30, 2024 08:48
@GitHK GitHK requested review from sanderegg and pcrespov as code owners July 30, 2024 08:48
@GitHK GitHK requested a review from matusdrobuliak66 July 30, 2024 08:49
Copy link

codecov bot commented Jul 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 64.0%. Comparing base (cafbf96) to head (c1793bf).
Report is 389 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #6122      +/-   ##
=========================================
- Coverage    84.5%   64.0%   -20.6%     
=========================================
  Files          10     591     +581     
  Lines         214   29357   +29143     
  Branches       25     205     +180     
=========================================
+ Hits          181   18794   +18613     
- Misses         23   10512   +10489     
- Partials       10      51      +41     
Flag Coverage Δ
integrationtests 63.6% <ø> (?)
unittests 97.9% <100.0%> (+13.3%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...ervice_dynamic_scheduler/api/rest/_dependencies.py 100.0% <ø> (ø)
...imcore_service_dynamic_scheduler/api/rest/_meta.py 100.0% <100.0%> (ø)
...ore_service_dynamic_scheduler/api/rpc/_services.py 100.0% <100.0%> (ø)
...simcore_service_dynamic_scheduler/core/settings.py 100.0% <100.0%> (ø)
...c_scheduler/services/director_v2/_public_client.py 92.0% <ø> (ø)
...mic_scheduler/services/director_v2/_thin_client.py 100.0% <100.0%> (ø)

... and 595 files with indirect coverage changes

Copy link
Member

@sanderegg sanderegg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks

@GitHK GitHK enabled auto-merge (squash) July 30, 2024 14:13
Copy link

@GitHK GitHK merged commit ef70a5c into ITISFoundation:master Jul 30, 2024
57 checks passed
@GitHK GitHK deleted the pr-osparc-fix-mypy-in-dy-scheduler branch July 30, 2024 14:45
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request Aug 15, 2024
67 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a:dynamic-scheduler t:maintenance Some planned maintenance work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants