♻️Maintenance: mypy director v2

[sanderegg]

What do these changes do?

• relates to Fix Mypy issues ASAP #6115

Related issue/s

How to test

Dev-ops checklist

• No ENV changes or I properly updated ENV (read the instruction)

[codecov]

Codecov Report

Attention: Patch coverage is 90.00000% with 16 lines in your changes missing coverage. Please review.

Project coverage is 88.5%. Comparing base (cafbf96) to head (ede5fde).
Report is 398 commits behind head on master.

Files	Patch %	Lines
...c_sidecar/scheduler/_core/_events_user_services.py	66.6%	5 Missing ⚠️
...s/dynamic_sidecar/scheduler/_core/_events_utils.py	76.1%	5 Missing ⚠️
...-v2/src/simcore_service_director_v2/core/errors.py	0.0%	2 Missing ⚠️
...ector_v2/modules/osparc_variables/substitutions.py	50.0%	2 Missing ⚠️
...simcore_service_director_v2/modules/dask_client.py	92.3%	1 Missing ⚠️
...e_service_director_v2/modules/dask_clients_pool.py	0.0%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff            @@
##           master   #6125      +/-   ##
=========================================
+ Coverage    84.5%   88.5%    +3.9%     
=========================================
  Files          10    1019    +1009     
  Lines         214   45442   +45228     
  Branches       25     234     +209     
=========================================
+ Hits          181   40234   +40053     
- Misses         23    5150    +5127     
- Partials       10      58      +48     

Flag	Coverage Δ
integrationtests	64.9% <80.6%> (?)
unittests	85.8% <78.1%> (+1.2%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files	Coverage Δ
...core-sdk/src/simcore_sdk/node_ports_v2/__init__.py	100.0% <100.0%> (ø)
...e_service_director_v2/api/dependencies/__init__.py	100.0% <100.0%> (ø)
...e_service_director_v2/api/dependencies/database.py	95.0% <100.0%> (ø)
...e_director_v2/api/dependencies/dynamic_services.py	100.0% <100.0%> (ø)
...mcore_service_director_v2/api/errors/http_error.py	100.0% <100.0%> (ø)
...simcore_service_director_v2/api/routes/clusters.py	96.2% <100.0%> (ø)
...ervice_director_v2/api/routes/dynamic_scheduler.py	94.5% <100.0%> (ø)
...service_director_v2/api/routes/dynamic_services.py	90.9% <100.0%> (ø)
...service_director_v2/cli/_close_and_save_service.py	100.0% <ø> (ø)
...or-v2/src/simcore_service_director_v2/cli/_core.py	88.5% <100.0%> (ø)
... and 40 more

... and 979 files with indirect coverage changes

[GitHK]

All good, think I solved your issue with the retry.

[GitHK]

thanks for pointing out the issue

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
1.1% Duplication on New Code

See analysis details on SonarCloud

[matusdrobuliak66]

👍