Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ folders api #6132

Merged
merged 11 commits into from
Aug 7, 2024
Merged

Conversation

matusdrobuliak66
Copy link
Contributor

@matusdrobuliak66 matusdrobuliak66 commented Aug 2, 2024

What do these changes do?

  • ✨ crud operations on folders
  • PUT on projects/folders (Project movement)

Related issue/s

How to test

Dev-ops checklist

@matusdrobuliak66 matusdrobuliak66 self-assigned this Aug 2, 2024
@matusdrobuliak66 matusdrobuliak66 added this to the Tom Bombadil milestone Aug 2, 2024
Copy link

codecov bot commented Aug 2, 2024

Codecov Report

Attention: Patch coverage is 58.10056% with 75 lines in your changes missing coverage. Please review.

Project coverage is 84.7%. Comparing base (cafbf96) to head (ae06253).
Report is 405 commits behind head on master.

Files Patch % Lines
.../simcore_service_webserver/folders/_folders_api.py 38.7% 19 Missing ⚠️
...ase/src/simcore_postgres_database/utils_folders.py 25.0% 14 Missing and 1 partial ⚠️
...simcore_service_webserver/projects/_folders_api.py 51.7% 14 Missing ⚠️
...re_service_webserver/projects/_folders_handlers.py 70.8% 14 Missing ⚠️
...ore_service_webserver/folders/_folders_handlers.py 22.2% 7 Missing ⚠️
...server/src/simcore_service_webserver/groups/_db.py 50.0% 3 Missing ⚠️
...server/src/simcore_service_webserver/groups/api.py 50.0% 3 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #6132      +/-   ##
=========================================
+ Coverage    84.5%   84.7%    +0.1%     
=========================================
  Files          10    1284    +1274     
  Lines         214   54483   +54269     
  Branches       25     801     +776     
=========================================
+ Hits          181   46176   +45995     
- Misses         23    8130    +8107     
- Partials       10     177     +167     
Flag Coverage Δ
integrationtests 63.7% <54.4%> (?)
unittests 82.4% <58.1%> (-2.2%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...rc/models_library/api_schemas_webserver/folders.py 100.0% <100.0%> (ø)
.../src/simcore_service_webserver/groups/_handlers.py 82.1% <100.0%> (ø)
...core_service_webserver/projects/_nodes_handlers.py 91.1% <100.0%> (ø)
...r/src/simcore_service_webserver/projects/plugin.py 100.0% <100.0%> (ø)
..._service_webserver/security/_authz_access_roles.py 100.0% <ø> (ø)
...rc/simcore_service_webserver/socketio/_handlers.py 86.2% <100.0%> (ø)
...server/src/simcore_service_webserver/groups/_db.py 93.2% <50.0%> (ø)
...server/src/simcore_service_webserver/groups/api.py 89.0% <50.0%> (ø)
...ore_service_webserver/folders/_folders_handlers.py 68.0% <22.2%> (ø)
...simcore_service_webserver/projects/_folders_api.py 51.7% <51.7%> (ø)
... and 3 more

... and 1240 files with indirect coverage changes

@matusdrobuliak66 matusdrobuliak66 marked this pull request as ready for review August 7, 2024 11:38
Copy link
Member

@odeimaiz odeimaiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

merci

Copy link

sonarqubecloud bot commented Aug 7, 2024

@mrnicegyu11 mrnicegyu11 enabled auto-merge (squash) August 7, 2024 15:31
@mrnicegyu11 mrnicegyu11 disabled auto-merge August 7, 2024 15:31
@mrnicegyu11 mrnicegyu11 merged commit f677f98 into ITISFoundation:master Aug 7, 2024
37 checks passed
@matusdrobuliak66 matusdrobuliak66 changed the title ✨ projects api ✨ folders api Aug 7, 2024
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request Aug 15, 2024
67 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants