Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

♻️Maintenance: mypy postgres database package #6140

Merged
merged 3 commits into from
Aug 6, 2024

Conversation

sanderegg
Copy link
Member

@sanderegg sanderegg commented Aug 6, 2024

What do these changes do?

mypy postgres-db package

Related issue/s

How to test

Dev-ops checklist

@sanderegg sanderegg added the a:database associated to postgres service and postgres-database package label Aug 6, 2024
@sanderegg sanderegg added this to the Tom Bombadil milestone Aug 6, 2024
@sanderegg sanderegg self-assigned this Aug 6, 2024
@sanderegg sanderegg requested a review from GitHK August 6, 2024 06:00
Copy link

codecov bot commented Aug 6, 2024

Codecov Report

Attention: Patch coverage is 76.92308% with 3 lines in your changes missing coverage. Please review.

Project coverage is 89.0%. Comparing base (cafbf96) to head (b7878af).
Report is 399 commits behind head on master.

Files Patch % Lines
...gres-database/src/simcore_postgres_database/cli.py 0.0% 3 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #6140      +/-   ##
=========================================
+ Coverage    84.5%   89.0%    +4.4%     
=========================================
  Files          10    1259    +1249     
  Lines         214   53043   +52829     
  Branches       25     698     +673     
=========================================
+ Hits          181   47246   +47065     
- Misses         23    5640    +5617     
- Partials       10     157     +147     
Flag Coverage Δ
integrationtests 64.9% <ø> (?)
unittests 86.7% <76.9%> (+2.1%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...abase/src/simcore_postgres_database/models/base.py 100.0% <100.0%> (ø)
...e/src/simcore_postgres_database/utils_aiopg_orm.py 82.8% <100.0%> (ø)
...se/src/simcore_postgres_database/utils_payments.py 93.9% <100.0%> (ø)
...abase/src/simcore_postgres_database/utils_users.py 82.5% <100.0%> (ø)
...gres-database/src/simcore_postgres_database/cli.py 62.0% <0.0%> (ø)

... and 1221 files with indirect coverage changes

Copy link
Contributor

@matusdrobuliak66 matusdrobuliak66 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot, you are really fast! :) I thought I should take care of this one. Cool thanks.

@sanderegg sanderegg force-pushed the mypy/postgres-database branch from 788457f to 89a3d38 Compare August 6, 2024 06:41
Copy link

sonarqubecloud bot commented Aug 6, 2024

@sanderegg sanderegg merged commit d873259 into ITISFoundation:master Aug 6, 2024
57 checks passed
@sanderegg sanderegg deleted the mypy/postgres-database branch August 6, 2024 08:05
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request Aug 15, 2024
67 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a:database associated to postgres service and postgres-database package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants