Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Fixes broken anonymous user opening templates #6149

Merged

Conversation

GitHK
Copy link
Contributor

@GitHK GitHK commented Aug 7, 2024

What do these changes do?

This will allow for the e2e to properly run the BIOS template in master@z43

  • 🐛 Fixes an issue where the webserver did not update the project networks for anonymous user templates, only the comp jobs were updated.
  • 🐛 Fixes an issue where the director-v2 was reporting the wrong error. It is now reporting correctly.

Related issue/s

How to test

Dev-ops checklist

@GitHK GitHK self-assigned this Aug 7, 2024
@GitHK GitHK added bug buggy, it does not work as expected a:webserver issue related to the webserver service t:maintenance Some planned maintenance work a:director-v2 issue related with the director-v2 service labels Aug 7, 2024
@GitHK GitHK added this to the Tom Bombadil milestone Aug 7, 2024
@GitHK GitHK marked this pull request as ready for review August 7, 2024 14:02
Copy link

codecov bot commented Aug 7, 2024

Codecov Report

Attention: Patch coverage is 63.63636% with 4 lines in your changes missing coverage. Please review.

Project coverage is 85.4%. Comparing base (cafbf96) to head (183b4e0).
Report is 407 commits behind head on master.

Files Patch % Lines
...-v2/src/simcore_service_director_v2/core/errors.py 50.0% 2 Missing ⚠️
...or_v2/modules/db/repositories/projects_networks.py 50.0% 1 Missing ⚠️
...e_service_director_v2/modules/projects_networks.py 50.0% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #6149      +/-   ##
=========================================
+ Coverage    84.5%   85.4%    +0.8%     
=========================================
  Files          10     577     +567     
  Lines         214   29385   +29171     
  Branches       25     234     +209     
=========================================
+ Hits          181   25096   +24915     
- Misses         23    4229    +4206     
- Partials       10      60      +50     
Flag Coverage Δ
integrationtests 63.7% <54.5%> (?)
unittests 86.6% <63.6%> (+2.0%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...rc/simcore_service_director_v2/core/application.py 96.3% <100.0%> (ø)
...ce_webserver/studies_dispatcher/_studies_access.py 86.2% <100.0%> (ø)
...or_v2/modules/db/repositories/projects_networks.py 69.5% <50.0%> (ø)
...e_service_director_v2/modules/projects_networks.py 74.4% <50.0%> (ø)
...-v2/src/simcore_service_director_v2/core/errors.py 77.3% <50.0%> (ø)

... and 582 files with indirect coverage changes

Copy link

sonarqubecloud bot commented Aug 8, 2024

@GitHK GitHK enabled auto-merge (squash) August 8, 2024 06:58
@GitHK GitHK merged commit e25c5e5 into ITISFoundation:master Aug 8, 2024
57 checks passed
@GitHK GitHK deleted the pr-osparc-fix-anonymous-user-networks-fail branch August 8, 2024 07:32
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request Aug 15, 2024
67 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a:director-v2 issue related with the director-v2 service a:webserver issue related to the webserver service bug buggy, it does not work as expected t:maintenance Some planned maintenance work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants