-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🎨 make folders optional + improvements ⚠️ #6155
🎨 make folders optional + improvements ⚠️ #6155
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #6155 +/- ##
=========================================
+ Coverage 84.5% 88.1% +3.5%
=========================================
Files 10 1349 +1339
Lines 214 58150 +57936
Branches 25 1250 +1225
=========================================
+ Hits 181 51249 +51068
- Misses 23 6633 +6610
- Partials 10 268 +258
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
merci
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok consider my comments. thanks
services/web/server/src/simcore_service_webserver/folders/_folders_handlers.py
Outdated
Show resolved
Hide resolved
services/web/server/src/simcore_service_webserver/projects/db.py
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thx. Left some suggestions
services/web/server/src/simcore_service_webserver/folders/_folders_handlers.py
Outdated
Show resolved
Hide resolved
services/web/server/src/simcore_service_webserver/projects/db.py
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great, thank you very much
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great!thx!
…osparc-simcore into enable-disable-folders
Quality Gate passedIssues Measures |
What do these changes do?
Related issue/s
How to test
Dev-ops checklist