-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
♻️ Maintenance: Fixes mypy in api-server #6175
♻️ Maintenance: Fixes mypy in api-server #6175
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #6175 +/- ##
=========================================
+ Coverage 84.5% 88.1% +3.5%
=========================================
Files 10 1431 +1421
Lines 214 60082 +59868
Branches 25 1438 +1413
=========================================
+ Hits 181 52966 +52785
- Misses 23 6816 +6793
- Partials 10 300 +290
Flags with carried forward coverage won't be shown. Click here to find out more.
|
c65e784
to
81cc1b7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks! maybe we can check some of these together.
services/api-server/src/simcore_service_api_server/api/routes/meta.py
Outdated
Show resolved
Hide resolved
services/api-server/src/simcore_service_api_server/api/routes/meta.py
Outdated
Show resolved
Hide resolved
services/api-server/src/simcore_service_api_server/api/routes/solvers_jobs_getters.py
Outdated
Show resolved
Hide resolved
services/api-server/src/simcore_service_api_server/api/routes/studies_jobs.py
Show resolved
Hide resolved
services/api-server/src/simcore_service_api_server/models/domain/projects.py
Outdated
Show resolved
Hide resolved
services/api-server/src/simcore_service_api_server/models/schemas/files.py
Show resolved
Hide resolved
services/api-server/src/simcore_service_api_server/services/solver_job_models_converters.py
Outdated
Show resolved
Hide resolved
services/api-server/src/simcore_service_api_server/services/solver_job_models_converters.py
Show resolved
Hide resolved
services/api-server/src/simcore_service_api_server/models/api_resources.py
Show resolved
Hide resolved
dd8334d
to
51153dc
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks
5f9ef01
to
c56c38e
Compare
edcecc0
to
e8acb67
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 thanks
e8acb67
to
cfeb7b1
Compare
Quality Gate passedIssues Measures |
What do these changes do?
Following procedure in #6115, this PR fixes errors reported by
mypy
inapi-server
serviceRelated issue/s
How to test
Dev-ops checklist