Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

♻️ Maintenance: Fixes mypy in api-server #6175

Merged
merged 29 commits into from
Aug 19, 2024

Conversation

pcrespov
Copy link
Member

@pcrespov pcrespov commented Aug 12, 2024

What do these changes do?

Following procedure in #6115, this PR fixes errors reported by mypy in api-server service

Related issue/s

How to test

cd services/api-server
make install-dev
make mypy

Dev-ops checklist

@pcrespov pcrespov self-assigned this Aug 12, 2024
@pcrespov pcrespov added a:api framework api, data schemas, t:maintenance Some planned maintenance work labels Aug 12, 2024
@pcrespov pcrespov added this to the Tom Bombadil milestone Aug 12, 2024
@pcrespov pcrespov mentioned this pull request Aug 12, 2024
1 task
Copy link

codecov bot commented Aug 12, 2024

Codecov Report

Attention: Patch coverage is 95.04950% with 5 lines in your changes missing coverage. Please review.

Project coverage is 88.1%. Comparing base (cafbf96) to head (2e77746).
Report is 446 commits behind head on master.

Files Patch % Lines
...simcore_service_api_server/models/api_resources.py 60.0% 2 Missing ⚠️
..._service_api_server/services/solver_job_outputs.py 50.0% 2 Missing ⚠️
...simcore_service_api_server/models/schemas/files.py 50.0% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #6175      +/-   ##
=========================================
+ Coverage    84.5%   88.1%    +3.5%     
=========================================
  Files          10    1431    +1421     
  Lines         214   60082   +59868     
  Branches       25    1438    +1413     
=========================================
+ Hits          181   52966   +52785     
- Misses         23    6816    +6793     
- Partials       10     300     +290     
Flag Coverage Δ
integrationtests 64.8% <100.0%> (?)
unittests 86.0% <95.0%> (+1.5%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...s/models-library/src/models_library/basic_regex.py 100.0% <100.0%> (ø)
...s/models-library/src/models_library/basic_types.py 98.4% <100.0%> (ø)
...odels-library/src/models_library/services_types.py 91.8% <100.0%> (ø)
...kages/service-library/src/servicelib/utils_meta.py 100.0% <100.0%> (ø)
...api-server/src/simcore_service_api_server/_meta.py 100.0% <100.0%> (ø)
...re_service_api_server/api/dependencies/database.py 94.4% <100.0%> (ø)
...src/simcore_service_api_server/api/routes/files.py 78.5% <100.0%> (ø)
...c/simcore_service_api_server/api/routes/solvers.py 65.0% <ø> (ø)
...core_service_api_server/api/routes/solvers_jobs.py 100.0% <ø> (ø)
...vice_api_server/api/routes/solvers_jobs_getters.py 93.3% <ø> (ø)
... and 34 more

... and 1343 files with indirect coverage changes

@sanderegg sanderegg modified the milestones: Tom Bombadil, Eisbock Aug 13, 2024
@pcrespov pcrespov force-pushed the is6115/mypy-api-server branch from c65e784 to 81cc1b7 Compare August 13, 2024 17:14
@pcrespov pcrespov requested a review from sanderegg as a code owner August 13, 2024 17:14
@pcrespov pcrespov changed the title ♻️ Fixes mypy in api-server ♻️ Maintenance: Fixes mypy in api-server Aug 13, 2024
Copy link
Member

@sanderegg sanderegg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks! maybe we can check some of these together.

@pcrespov pcrespov marked this pull request as draft August 14, 2024 07:55
@pcrespov pcrespov force-pushed the is6115/mypy-api-server branch 3 times, most recently from dd8334d to 51153dc Compare August 15, 2024 14:34
@pcrespov pcrespov marked this pull request as ready for review August 15, 2024 14:41
Copy link
Contributor

@matusdrobuliak66 matusdrobuliak66 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks

@pcrespov pcrespov force-pushed the is6115/mypy-api-server branch from edcecc0 to e8acb67 Compare August 16, 2024 15:17
Copy link
Contributor

@GitHK GitHK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 thanks

@pcrespov pcrespov force-pushed the is6115/mypy-api-server branch from e8acb67 to cfeb7b1 Compare August 19, 2024 09:17
Copy link

@pcrespov pcrespov merged commit bc1d290 into ITISFoundation:master Aug 19, 2024
57 checks passed
@pcrespov pcrespov deleted the is6115/mypy-api-server branch August 19, 2024 12:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a:api framework api, data schemas, t:maintenance Some planned maintenance work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants