Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

⬆️ Upgrade to traefik v3 (2nd trial) #6190

Merged

Conversation

mrnicegyu11
Copy link
Member

@mrnicegyu11 mrnicegyu11 commented Aug 15, 2024

This reverts commit b1416b4.
This needs to be merged together with ITISFoundation/osparc-ops-environments#743

What do these changes do?

Upgrade traefik major version to v3

Related issue/s

ITISFoundation/osparc-ops-environments#743

How to test

We need to check whether on both master-deployments legacy and v2 dynamic services start, there was an issue the last time this was merged.

Dev-ops checklist

This reverts commit b1416b4.
@mrnicegyu11 mrnicegyu11 added the t:enhancement Improvement or request on an existing feature label Aug 15, 2024
@mrnicegyu11 mrnicegyu11 added this to the Eisbock milestone Aug 15, 2024
@mrnicegyu11 mrnicegyu11 self-assigned this Aug 15, 2024
Copy link

codecov bot commented Aug 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.1%. Comparing base (cafbf96) to head (ee1f7a3).
Report is 474 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #6190      +/-   ##
=========================================
+ Coverage    84.5%   88.1%    +3.5%     
=========================================
  Files          10    1471    +1461     
  Lines         214   61003   +60789     
  Branches       25    2063    +2038     
=========================================
+ Hits          181   53778   +53597     
- Misses         23    6910    +6887     
- Partials       10     315     +305     
Flag Coverage Δ
integrationtests 64.8% <ø> (?)
unittests 86.1% <ø> (+1.5%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...ules/dynamic_sidecar/docker_service_specs/proxy.py 100.0% <ø> (ø)
.../director/src/simcore_service_director/producer.py 66.2% <ø> (ø)

... and 1419 files with indirect coverage changes

services/docker-compose.yml Show resolved Hide resolved
Copy link
Contributor

@matusdrobuliak66 matusdrobuliak66 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

Copy link
Member

@sanderegg sanderegg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

services/docker-compose.local.yml Show resolved Hide resolved
services/docker-compose.yml Show resolved Hide resolved
Copy link

@mrnicegyu11 mrnicegyu11 merged commit 13f7ace into ITISFoundation:master Aug 28, 2024
53 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
t:enhancement Improvement or request on an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants