Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 fixes broken test in servicelib + code deprecation #6216

Merged
merged 3 commits into from
Aug 21, 2024

Conversation

GitHK
Copy link
Contributor

@GitHK GitHK commented Aug 20, 2024

@GitHK GitHK self-assigned this Aug 20, 2024
@GitHK GitHK added a:services-library issues on packages/service-libs t:maintenance Some planned maintenance work labels Aug 20, 2024
@GitHK GitHK added this to the Eisbock milestone Aug 20, 2024
Copy link

codecov bot commented Aug 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.8%. Comparing base (cafbf96) to head (a1d9330).
Report is 455 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #6216      +/-   ##
=========================================
+ Coverage    84.5%   87.8%    +3.2%     
=========================================
  Files          10    1143    +1133     
  Lines         214   50257   +50043     
  Branches       25     779     +754     
=========================================
+ Hits          181   44160   +43979     
- Misses         23    5927    +5904     
- Partials       10     170     +160     
Flag Coverage Δ
integrationtests 65.0% <ø> (?)
unittests 85.3% <ø> (+0.8%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 1153 files with indirect coverage changes

@GitHK GitHK changed the title 🐛 fixes broken test in service lib 🐛 fixes broken test in servicelib + code deprecation Aug 20, 2024
@GitHK GitHK marked this pull request as ready for review August 20, 2024 13:04
@GitHK GitHK requested a review from pcrespov as a code owner August 20, 2024 13:04
Copy link
Member

@sanderegg sanderegg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@GitHK GitHK enabled auto-merge (squash) August 21, 2024 05:52
Copy link

@GitHK GitHK merged commit db96384 into ITISFoundation:master Aug 21, 2024
57 checks passed
@GitHK GitHK deleted the pr-osparc-fix-broken-test branch August 21, 2024 06:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a:services-library issues on packages/service-libs t:maintenance Some planned maintenance work
Projects
None yet
5 participants